-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix doctests for the Interfaces chapter
[ci skip]
- Loading branch information
Showing
1 changed file
with
5 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f2ce0f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh dear, I think merging #11774 managed to break these again, sorry. Is there a bug somewhere or are these just fragile due to #265?
6f2ce0f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably just overly fragile. I like the exposition, but this sort of incremental definition is flirting with bugs… especially as folks will likely try things on their own and then wonder why later things are broken. I'll change it to define everything all at once.
6f2ce0f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like this? https://gist.github.com/7f177ecb0708db6dd88c
6f2ce0f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I committed that in 69232e0, please adjust if you'd prefer something different.