fix review comments

JuliaLang · Oct 15, 2017 · 71fe871 · 71fe871
1 parent 89b4d68
commit 71fe871
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -316,7 +316,7 @@ Library improvements
 
   * REPL Undo via Ctrl-/ and Ctrl-_
 
-  * `diagm` now accepts several diagonal index/vector pairs ([#24047]).
+  * `diagm` now accepts several diagonal index/vector `Pair`s ([#24047]).
 
   * New function `equalto(x)`, which returns a function that compares its argument to `x`
     using `isequal` ([#23812]).

diff --git a/base/linalg/dense.jl b/base/linalg/dense.jl
@@ -270,8 +270,11 @@ diag(A::AbstractMatrix, k::Integer=0) = A[diagind(A,k)]
 
 Construct a square matrix from `Pair`s of diagonals and vectors.
 Vector `kv.second` will be placed on the `kv.first` diagonal.
+`diagm` constructs a full matrix; if you want storage-efficient
+versions with fast arithmetic, see [`Diagonal`](@ref), [`Bidiagonal`](@ref)
+[`Tridiagonal`](@ref) and [`SymTridiagonal`](@ref).
 
-See also: [`spdiagm`](@ref), [`Diagonal`](@ref)
+See also: [`spdiagm`](@ref)
 
 # Examples
 ```jldoctest

diff --git a/base/linalg/generic.jl b/base/linalg/generic.jl
@@ -739,7 +739,7 @@ of the [`eltype`](@ref) of `A`.
 julia> rank(eye(3))
 3
 
-julia> rank(0 => diagm([1, 0, 2]))
+julia> rank(diagm(0 => [1, 0, 2]))
 2
 
 julia> rank(diagm(0 => [1, 0.001, 2]), 0.1)