inference: add missing MustAlias widening in _getfield_tfunc (#54996

) Otherwise it may result in missing `⊑` method error in uses cases by external abstract interpreters using `MustAliasesLattice` like JET.
JuliaLang · Jul 3, 2024 · 74cead1 · 74cead1
1 parent b7af64f
commit 74cead1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/base/compiler/tfuncs.jl b/base/compiler/tfuncs.jl
@@ -1095,7 +1095,7 @@ end
 end
 
 @nospecs function _getfield_tfunc(𝕃::AnyMustAliasesLattice, s00, name, setfield::Bool)
- return _getfield_tfunc(widenlattice(𝕃), widenmustalias(s00), name, setfield)
+ return _getfield_tfunc(widenlattice(𝕃), widenmustalias(s00), widenmustalias(name), setfield)
 end
 
 @nospecs function _getfield_tfunc(𝕃::PartialsLattice, s00, name, setfield::Bool)

diff --git a/test/compiler/inference.jl b/test/compiler/inference.jl
@@ -2569,6 +2569,14 @@ Base.return_types(intermustalias_edgecase, (Any,); interp=MustAliasInterpreter()
  intermustalias_edgecase(x)
 end |> only === Core.Compiler.InterMustAlias
 
+@test Base.infer_return_type((AliasableField,Integer,); interp=MustAliasInterpreter()) do a, x
+ s = (;x)
+ if getfield(a, :f) isa Symbol
+ return getfield(s, getfield(a, :f))
+ end
+ return 0
+end == Integer
+
 function f25579(g)
  h = g[]
  t = (h === nothing)