Merge pull request #16297 from stevengj/quote_eq_sym

fix #16295: make sure :(==) is parenthesized in deprecation warnings

base/deprecated.jl

@@ -1096,13 +1096,15 @@ end
 #15032: Expressions like Base.(:+) now call broadcast. Since calls
 # to broadcast(x, ::Symbol) are unheard of, and broadcast(x, ::Integer)
 # are unlikely, we can treat these as deprecated getfield calls.
+# (See julia-syntax.scm for the Base.(:+)(...) = ... deprecation.)
 function broadcast(x::Any, i::Union{Integer,Symbol})
  depwarn("x.(i) is deprecated; use getfield(x, i) instead.", :broadcast)
  getfield(x, i)
 end
 # clearer to be more explicit in the warning for the Module case
 function broadcast(m::Module, s::Symbol)
- depwarn("$m.(:$s) is deprecated; use $m.:$s or getfield($m, :$s) instead.", :broadcast)
+ S = repr(s) # 16295
+ depwarn("$m.($S) is deprecated; use $m.$S or getfield($m, $S) instead.", :broadcast)
  getfield(m, s)
 end
 # expressions like f.(3) should still call broadcast for f::Function,

src/ast.scm

@@ -41,7 +41,8 @@
  ((ref) (string (deparse (cadr e)) #\[ (deparse-arglist (cddr e)) #\]))
  ((curly) (string (deparse (cadr e)) #\{ (deparse-arglist (cddr e)) #\}))
  ((quote inert)
- (if (symbol? (cadr e))
+ (if (and (symbol? (cadr e))
+ (not (= (string.char (string (cadr e)) 0) #\=)))
  (string ":" (deparse (cadr e)))
  (string ":(" (deparse (cadr e)) ")")))
  ((vect) (string #\[ (deparse-arglist (cdr e)) #\]))

src/julia-syntax.scm

@@ -232,9 +232,10 @@
  (s (if (symbol? s_) s_
  (if (and (length= s_ 1) (symbol? (car s_))) (car s_) #f))))
  (if s
- (let ((newe (list (car e) (cadr e) (cadr (caddr e)))))
- (syntax-deprecation #f (string (deparse (cadr e)) ".(:" s ")")
- (string (deparse (cadr e)) ".:" s))
+ (let ((newe (list (car e) (cadr e) (cadr (caddr e))))
+ (S (deparse `(quote ,s)))) ; #16295
+ (syntax-deprecation #f (string (deparse (cadr e)) ".(" S ")")
+ (string (deparse (cadr e)) "." S))
  newe)
  e))
  e))