Skip to content

Commit

Permalink
devdocs: slots live in CodeInfo, not MethodInstance (fix #38840) (#38843
Browse files Browse the repository at this point in the history 
)
  • Loading branch information
@ulysses4ever
ulysses4ever authored Dec 12, 2020
1 parent 26b73d6 commit 7d137e9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion doc/src/devdocs/ast.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ types exist in lowered form:
Identifies arguments and local variables by consecutive numbering. `Slot` is an abstract type
with subtypes `SlotNumber` and `TypedSlot`. Both types have an integer-valued `id` field giving
the slot index. Most slots have the same type at all uses, and so are represented with `SlotNumber`.
The types of these slots are found in the `slottypes` field of their `MethodInstance` object.
The types of these slots are found in the `slottypes` field of their `CodeInfo` object.
Slots that require per-use type annotations are represented with `TypedSlot`, which has a `typ`
field.

Expand Down

4 comments on commit 7d137e9

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong when running your job:

ProcessFailedException(Base.Process[Process(`git fetch --all`, ProcessExited(1))])

cc @christopher-dG

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt

Please sign in to comment.