Don't keep files open in cholmod

the non-do-block form of open should really be avoided
JuliaLang · Feb 26, 2015 · 93af265 · 93af265
1 parent bef6bf3
commit 93af265
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/base/sparse/cholmod.jl b/base/sparse/cholmod.jl
@@ -726,10 +726,9 @@ end
 Sparse(A::Dense) = dense_to_sparse(A, Cint)
 Sparse(L::Factor) = factor_to_sparse!(copy(L))
 function Sparse(filename::ByteString)
-    f = open(filename)
-    A = read_sparse(CFILE(f), SuiteSparse_long)
-    close(f)
-    A
+    open(filename) do f
+        return read_sparse(CFILE(f), SuiteSparse_long)
+    end
 end
 
 ## convertion back to base Julia types