Statistics.median: return first NaN if there are any

Fix #29900
JuliaLang · Nov 2, 2018 · 989d0b4 · 989d0b4
1 parent 13694f4
commit 989d0b4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/stdlib/Statistics/src/Statistics.jl b/stdlib/Statistics/src/Statistics.jl
@@ -694,7 +694,10 @@ Like [`median`](@ref), but may overwrite the input vector.
 function median!(v::AbstractVector)
     isempty(v) && throw(ArgumentError("median of an empty array is undefined, $(repr(v))"))
     eltype(v)>:Missing && any(ismissing, v) && return missing
-    (eltype(v)<:AbstractFloat || eltype(v)>:AbstractFloat) && any(isnan, v) && return NaN
+    if eltype(v)<:AbstractFloat || eltype(v)>:AbstractFloat
+        i = findfirst(isnan, v)
+        i !== nothing && return v[i]
+    end
     inds = axes(v, 1)
     n = length(inds)
     mid = div(first(inds)+last(inds),2)

diff --git a/stdlib/Statistics/test/runtests.jl b/stdlib/Statistics/test/runtests.jl
@@ -57,6 +57,13 @@ end
     @test median!([1 2; 3 4]) == 2.5
 
     @test invoke(median, Tuple{AbstractVector}, 1:10) == median(1:10) == 5.5
+
+    @test median(Float32[1.0, NaN, 3.0]) === NaN32
+    @test median(Float32[1.0, -NaN, 3.0]) === -NaN32
+    @test median(Float16[1.0, NaN, 3.0]) === NaN16
+    @test median(Float16[1.0, -NaN, 3.0]) === -NaN16
+    @test median(BigFloat[1.0, NaN, 3.0]) isa BigFloat
+    @test isequal(median(BigFloat[1.0, NaN, 3.0]), NaN)
 end
 
 @testset "mean" begin