put back broadcast behavior with repeated indices, changed by #31300

JuliaLang · May 18, 2019 · 9fd7b93 · 9fd7b93
1 parent 4a38e79
commit 9fd7b93
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/julia-syntax.scm b/src/julia-syntax.scm
@@ -1444,10 +1444,8 @@
 (define (expand-update-operator- op op= lhs rhs declT)
   (let* ((e      (remove-argument-side-effects lhs))
          (newlhs (car e))
-         (temp   (and (eq? op= '|.=|) (pair? newlhs) (make-ssavalue)))
-         (newlhs (if (and temp (eq? (car newlhs) 'ref))
-                     (ref-to-view newlhs)
-                     newlhs))
+         (temp   (and (eq? op= '|.=|) (pair? newlhs) (not (eq? (car newlhs) 'ref))
+                      (make-ssavalue)))
          (e      (if temp
                      (cons temp (append (cdr e) (list `(= ,temp ,newlhs))))
                      e))

diff --git a/test/broadcast.jl b/test/broadcast.jl
@@ -817,4 +817,8 @@ end
 let a = rand(5), b = rand(5), c = copy(a)
     view(identity(a), 1:3) .+= view(b, 1:3)
     @test a == [(c+b)[1:3]; c[4:5]]
+
+    x = [1]
+    x[[1,1]] .+= 1
+    @test x == [2]
 end