inlining: fix the joint_effects calculation (#50117)

There are cases when `joint_effects` already has `:nothrow` tainted while the matches are fully covered.
JuliaLang · Jun 10, 2023 · a31c8ef · a31c8ef · nanosoldier · Jun 10, 2023
1 parent 0919cba
commit a31c8ef
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/base/compiler/abstractinterpretation.jl b/base/compiler/abstractinterpretation.jl
@@ -2603,11 +2603,9 @@ function abstract_eval_globalref(interp::AbstractInterpreter, g::GlobalRef, sv::
  nothrow = false
  if isa(rt, Const)
  consistent = ALWAYS_TRUE
+ nothrow = true
  if is_mutation_free_argtype(rt)
  inaccessiblememonly = ALWAYS_TRUE
- nothrow = true
- else
- nothrow = true
  end
  elseif isdefined_globalref(g)
  nothrow = true

diff --git a/base/compiler/ssair/inlining.jl b/base/compiler/ssair/inlining.jl
@@ -1406,7 +1406,7 @@ function compute_inlining_cases(@nospecialize(info::CallInfo), flag::UInt8, sig:
  fully_covered &= split_fully_covered
  end
 
- joint_effects = Effects(joint_effects; nothrow=fully_covered)
+ fully_covered || (joint_effects = Effects(joint_effects; nothrow=false))
 
  if handled_all_cases && revisit_idx !== nothing
  # we handled everything except one match with unmatched sparams,