Update base/compiler/typeinfer.jl

JuliaLang · Dec 30, 2022 · b34a421 · b34a421
1 parent 979ad5f
commit b34a421
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/base/compiler/typeinfer.jl b/base/compiler/typeinfer.jl
@@ -88,7 +88,10 @@ function finish_timing_profile(timing::Timing)
     ccall(:jl_typeinf_profiling_push_timing, Cvoid, (Any, Any,), _finished_timings, timing)
 end
 
-# TODO(PR): Comment this vector, explain that it should only be accessed thru C.
+# DO NOT ACCESS DIRECTLY. This vector should only be accessed through the 
+# functions above. It is a buffer that lives in the Julia module only to be *rooted*
+# for GC, but all accesses to the vector must go through C code, in order to be
+# thread safe.
 const _finished_timings = Timing[]
 
 # We keep a stack of the Timings for each of the MethodInstances currently being timed.