Skip to content

Commit

Permalink
Rename EnvHash to EnvDict
Browse files Browse the repository at this point in the history
  • Loading branch information
Andy Ferris committed Oct 21, 2017
1 parent f092e8f commit d543862
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
4 changes: 3 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -1042,7 +1042,7 @@ Deprecated or removed
* `num` and `den` have been deprecated in favor of `numerator` and `denominator` respectively ([#19233],[#19246]).
* `delete!(ENV::EnvHash, k::AbstractString, def)` has been deprecated in favor of
* `delete!(ENV::EnvDict, k::AbstractString, def)` has been deprecated in favor of
`pop!(ENV, k, def)`. Be aware that `pop!` returns `k` or `def`, whereas `delete!`
returns `ENV` or `def` ([#18012]).
Expand Down Expand Up @@ -1187,6 +1187,8 @@ Deprecated or removed
* Parsing string dates from a `Dates.DateFormat` object has been deprecated as part of a
larger effort toward faster, more extensible date parsing ([#20952]).
* `EnvHash` has been renamed to `EnvDict` ([#24167]).
Command-line option changes
---------------------------
Expand Down
5 changes: 4 additions & 1 deletion base/deprecated.jl
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ const _oldstyle_array_vcat_ = false

@deprecate write(x) write(STDOUT::IO, x)

function delete!(::EnvHash, k::AbstractString, def)
function delete!(::EnvDict, k::AbstractString, def)
depwarn("`delete!(ENV, k, def)` should be replaced with `pop!(ENV, k, def)`. Be aware that `pop!` returns `k` or `def`, while `delete!` returns `ENV` or `def`.", :delete!)
haskey(ENV,k) ? delete!(ENV,k) : def
end
Expand Down Expand Up @@ -1913,6 +1913,9 @@ end
@deprecate float(x::AbstractString) parse(Float64, x)
@deprecate float(a::AbstractArray{<:AbstractString}) parse.(Float64, a)

# issue #24167
@deprecate EnvHash EnvDict

# END 0.7 deprecations

# BEGIN 1.0 deprecations
Expand Down

0 comments on commit d543862

Please sign in to comment.