Fix replace (#36953) (#36959)

(cherry picked from commit 00f2133)
JuliaLang · Aug 10, 2020 · dc767cf · dc767cf
1 parent f3d8ffb
commit dc767cf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/base/strings/util.jl b/base/strings/util.jl
@@ -521,7 +521,7 @@ function replace(str::String, pat_repl::Pair; count::Integer=typemax(Int))
  i = k = nextind(str, k)
  end
  r = something(findnext(pattern,str,k), 0)
- r == 0:-1 || n == count && break
+ r === 0:-1 || n == count && break
  j, k = first(r), last(r)
  n += 1
  end

diff --git a/test/strings/util.jl b/test/strings/util.jl
@@ -297,6 +297,9 @@ end
  @test replace("a", in("a") => typeof) == "Char"
  @test replace("a", ['a'] => typeof) == "Char"
 
+ # Issue 36953
+ @test replace("abc", "" => "_", count=1) == "_abc"
+
 end
 
 @testset "chomp/chop" begin