Merge pull request #9143 from dhoegh/fix_shell_completion_error

Fix error regarding unescape_string introduced by #8838

base/REPLCompletions.jl

@@ -187,13 +187,13 @@ function completions(string, pos)
     partial = string[1:pos]
     inc_tag = Base.incomplete_tag(parse(partial , raise=false))
     if inc_tag in [:cmd, :string]
-        m = match(r"[\t\n\r\"'`@\$><=;|&\{]| (?!\\)",reverse(partial))
-        startpos = length(partial)-(m == nothing ? 1 : m.offset) + 2
+        m = match(r"[\t\n\r\"'`@\$><=;|&\{]| (?!\\)", reverse(partial))
+        startpos = length(partial) - (m == nothing ? 1 : m.offset) + 2
         r = startpos:pos
-        paths, r, success = complete_path(unescape_string(string[r]), pos)
+        paths, r, success = complete_path(replace(string[r], r"\\ ", " "), pos)
         if inc_tag == :string &&
            length(paths) == 1 &&                              # Only close if there's a single choice,
-           !isdir(unescape_string(string[startpos:start(r)-1] * paths[1])) &&  # except if it's a directory
+           !isdir(replace(string[startpos:start(r)-1] * paths[1], r"\\ ", " ")) &&  # except if it's a directory
            (length(string) <= pos || string[pos+1] != '"')    # or there's already a " at the cursor.
             paths[1] *= "\""
         end

test/replcompletions.jl

@@ -80,6 +80,10 @@ c,r,res = test_complete(s)
 @test r == 7:12
 @test length(c) == 1
 
+# `cd("C:\U should not make the repl crash due to escaping see comment #9137
+s = "cd(\"C:\\U"
+c,r,res = test_complete(s)
+
 ## Test completion of packages
 #mkp(p) = ((@assert !isdir(p)); mkdir(p))
 #temp_pkg_dir() do