Skip to content

Commit

Permalink
Merge pull request #34361 from JuliaLang/tb/diagonal_isapprox
Browse files Browse the repository at this point in the history
Use approximate comparison in LinearAlgebra diagonal tests.
  • Loading branch information
maleadt authored Jan 13, 2020
2 parents 5ebf660 + 78d1352 commit dd79e77
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions stdlib/LinearAlgebra/test/diagonal.jl
Original file line number Diff line number Diff line change
Expand Up @@ -471,32 +471,32 @@ end

# Triangular * Diagonal
R = T * D
@test R == Array(T) * Array(D)
@test R Array(T) * Array(D)
@test isa(R, rtype)

# Diagonal * Triangular
R = D * T
@test R == Array(D) * Array(T)
@test R Array(D) * Array(T)
@test isa(R, rtype)

# Adjoint of Triangular * Diagonal
R = T' * D
@test R == Array(T)' * Array(D)
@test R Array(T)' * Array(D)
@test isa(R, adjtype)

# Diagonal * Adjoint of Triangular
R = D * T'
@test R == Array(D) * Array(T)'
@test R Array(D) * Array(T)'
@test isa(R, adjtype)

# Transpose of Triangular * Diagonal
R = transpose(T) * D
@test R == transpose(Array(T)) * Array(D)
@test R transpose(Array(T)) * Array(D)
@test isa(R, adjtype)

# Diagonal * Transpose of Triangular
R = D * transpose(T)
@test R == Array(D) * transpose(Array(T))
@test R Array(D) * transpose(Array(T))
@test isa(R, adjtype)
end
end
Expand Down

2 comments on commit dd79e77

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

Please sign in to comment.