Allow showing of StepRangLen{T} with generic T (#49516)

JuliaLang · May 5, 2023 · ee95843 · ee95843
1 parent ad939df
commit ee95843
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/base/range.jl b/base/range.jl
@@ -1101,7 +1101,7 @@ show(io::IO, r::AbstractRange) = print(io, repr(first(r)), ':', repr(step(r)), '
 show(io::IO, r::UnitRange) = print(io, repr(first(r)), ':', repr(last(r)))
 show(io::IO, r::OneTo) = print(io, "Base.OneTo(", r.stop, ")")
 function show(io::IO, r::StepRangeLen)
-    if step(r) != 0
+    if !iszero(step(r))
         print(io, repr(first(r)), ':', repr(step(r)), ':', repr(last(r)))
     else
         # ugly temporary printing, to avoid 0:0:0 etc.

diff --git a/test/ranges.jl b/test/ranges.jl
@@ -2441,6 +2441,19 @@ end
     @test test_firstindex(StepRange{Union{Int64,Int128},Int}(Int64(1), 1, Int128(0)))
 end
 
+@testset "PR 49516" begin
+	struct PR49516 <: Signed
+		n::Int
+	end
+	PR49516(f::PR49516) = f
+	Base.:*(x::Integer, f::PR49516) = PR49516(*(x, f.n))
+	Base.:+(f1::PR49516, f2::PR49516) = PR49516(+(f1.n, f2.n))
+	Base.show(io::IO, f::PR49516) = print(io, "PR49516(", f.n, ")")
+
+	srl = StepRangeLen(PR49516(1), PR49516(2), 10)
+	@test sprint(show, srl) == "PR49516(1):PR49516(2):PR49516(19)"
+end
+
 @testset "Inline StepRange Construction #49270" begin
     x = rand(Float32, 80)
     a = rand(round(Int, length(x) / 2):length(x), 10^6)