-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Commit
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -85,6 +85,7 @@ end | |
@test searchsorted([1,2,3], 0) == 1:0 | ||
@test searchsorted([1,2,3], 4) == 4:3 | ||
|
||
# exercise the codepath in searchsorted* methods for ranges that check for zero step range | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
ivarne
Member
|
||
immutable ConstantRange{T} <: Range{T} | ||
val::T | ||
len::Int | ||
|
6 comments
on commit f1b7b62
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 to what @one-more-minute said. I haven't seen him disinclined at all, I imagine, like all of us, he's rather busy, and he has already done some very nice improvements to Docile.jl
that just need to be factored correctly into (and out of) Base.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@one-more-minute What about documenting type/immutable members, like Doxygen does?
I find that incredibly useful, it would be nice if a void string (or a ## say) after a member could be added to the documentation (with the info on type name, member name, type, file name/line number).
[this isn't about Doxygen at all, just about saving the metadata for later processing]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be a nice-to-have, but the first order of business is getting top-level docstrings into the language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, yes, fully agree!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ScottPJones, different Mike :)
documenting type/immutable members
I've thought about adding that to Docile, shouldn't be too much trouble if I have some time soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it's two Mikes doing all this neat stuff with documentation? OK, I'll try not to get confused again! 😀
This makes me wonder. When are we recommended to start using
@doc
syntax? MichaelHatherly/Docile.jl#141