fix deepcopy of IdDict. same issue as #19921. (#26136)

JuliaLang · Feb 22, 2018 · f82e845 · f82e845 · nanosoldier · Feb 22, 2018
1 parent 4115c9c
commit f82e845
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/base/deepcopy.jl b/base/deepcopy.jl
@@ -96,7 +96,7 @@ function _deepcopy_array_t(@nospecialize(x), T, stackdict::IdDict)
     return dest
 end
 
-function deepcopy_internal(x::Dict, stackdict::IdDict)
+function deepcopy_internal(x::Union{Dict,IdDict}, stackdict::IdDict)
     if haskey(stackdict, x)
         return stackdict[x]::typeof(x)
     end

diff --git a/test/copy.jl b/test/copy.jl
@@ -153,4 +153,14 @@ end
         @test bar2.foo ∈ keys(bar2.fooDict)
         @test bar2.fooDict[bar2.foo] != nothing
     end
+
+    let d = IdDict(rand(2) => rand(2) for i = 1:100)
+        d2 = deepcopy(d)
+        for k in keys(d2)
+            @test haskey(d2, k)
+        end
+        for k in keys(d)
+            @test haskey(d, k)
+        end
+    end
 end