Define trig functions for Diagonal (#24358)

JuliaLang · Oct 29, 2017 · f927508 · f927508
1 parent fcb5f42
commit f927508
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/base/linalg/diagonal.jl b/base/linalg/diagonal.jl
@@ -345,9 +345,13 @@ end
 eye(::Type{Diagonal{T}}, n::Int) where {T} = Diagonal(ones(T,n))
 
 # Matrix functions
-exp(D::Diagonal) = Diagonal(exp.(D.diag))
-log(D::Diagonal) = Diagonal(log.(D.diag))
-sqrt(D::Diagonal) = Diagonal(sqrt.(D.diag))
+for f in (:exp, :log, :sqrt,
+          :cos, :sin, :tan, :csc, :sec, :cot,
+          :cosh, :sinh, :tanh, :csch, :sech, :coth,
+          :acos, :asin, :atan, :acsc, :asec, :acot,
+          :acosh, :asinh, :atanh, :acsch, :asech, :acoth)
+    @eval $f(D::Diagonal) = Diagonal($f.(D.diag))
+end
 
 #Linear solver
 function A_ldiv_B!(D::Diagonal, B::StridedVecOrMat)

diff --git a/test/linalg/diagonal.jl b/test/linalg/diagonal.jl
@@ -71,13 +71,15 @@ srand(1)
             @test func(D) ≈ func(DM) atol=n^2*eps(relty)*(1+(elty<:Complex))
         end
         if relty <: BlasFloat
-            for func in (exp,)
+            for func in (exp, sinh, cosh, tanh, sech, csch, coth)
                 @test func(D) ≈ func(DM) atol=n^3*eps(relty)
             end
             @test log(Diagonal(abs.(D.diag))) ≈ log(abs.(DM)) atol=n^3*eps(relty)
         end
         if elty <: BlasComplex
-            for func in (logdet, sqrt)
+            for func in (logdet, sqrt, sin, cos, tan, sec, csc, cot,
+                         asin, acos, atan, asec, acsc, acot,
+                         asinh, acosh, atanh, asech, acsch, acoth)
                 @test func(D) ≈ func(DM) atol=n^2*eps(relty)*2
             end
         end