-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor shared cmake flags into a CMAKE_COMMON
add -DCMAKE_VERBOSE_MAKEFILE=ON keying off our VERBOSE flag
- Loading branch information
Showing
1 changed file
with
11 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faf6990
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @maleadt slight DRY cleanup
faf6990
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this seems like a better fit for these options.
I was going to propose adding the
libcxx
ones toLIBCXX_OPTIONS
instead (cfr.LIBGIT2_OPTS
), but it seems like that variable isn't used?faf6990
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If @Keno wants to, or doesn't object
faf6990
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go for it. I'll fix it later if anything breaks.