Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update utf8proc to 1.2 #10654

Closed
stevengj opened this issue Mar 28, 2015 · 1 comment
Closed

update utf8proc to 1.2 #10654

stevengj opened this issue Mar 28, 2015 · 1 comment
Labels
domain:unicode Related to unicode characters and encodings

Comments

@stevengj
Copy link
Member

Version 1.2 is now released (JuliaStrings/utf8proc#30), and we can update our deps. It was suggested by @tkelman that we switch back to just using a straight tarball rather than a git submodule.

The 1.2 release includes a utf8proc_charwidth function that we can use to replace both the system wcwidth and src/support/wcwidth.c and fix #3721. Possibly we should check the UTF8PROC_VERSION #defines etc. and fall back to wcwidth when USE_SYSTEM_UTF8PROC=1 and the system has an older version of utf8proc installed.
@stevengj stevengj added the domain:unicode Related to unicode characters and encodings label Mar 28, 2015
@stevengj
Copy link
Member Author

Should also fix #6939.

stevengj added a commit to stevengj/julia that referenced this issue Mar 28, 2015
@stevengj
update libmojibake -> utf8proc 1.2 (closes JuliaLang#10654)
49d0aa8
@stevengj stevengj mentioned this issue Mar 28, 2015
Merged
stevengj added a commit to stevengj/julia that referenced this issue Mar 29, 2015
@stevengj
update libmojibake -> utf8proc 1.2 (closes JuliaLang#10654)
6b6cc04
stevengj added a commit to stevengj/julia that referenced this issue Mar 30, 2015
@stevengj
update libmojibake -> utf8proc 1.2 (closes JuliaLang#10654)
881adb5
stevengj added a commit to stevengj/julia that referenced this issue Mar 30, 2015
@stevengj
update libmojibake -> utf8proc 1.2 (closes JuliaLang#10654); replace …
baefdfb 
…wcwidth by utf8proc_charwidth (fixes JuliaLang#3721, closes JuliaLang#6939)
stevengj added a commit to stevengj/julia that referenced this issue Mar 30, 2015
@stevengj
update libmojibake -> utf8proc 1.2 (closes JuliaLang#10654); replace …
9f58ecd 
…wcwidth by utf8proc_charwidth (fixes JuliaLang#3721, closes JuliaLang#6939)
stevengj added a commit to stevengj/julia that referenced this issue Mar 30, 2015
@stevengj
update libmojibake -> utf8proc 1.2 (closes JuliaLang#10654); replace …
0fb98b3 
…wcwidth by utf8proc_charwidth (fixes JuliaLang#3721, closes JuliaLang#6939)
stevengj added a commit to stevengj/julia that referenced this issue Mar 30, 2015
@stevengj
update libmojibake -> utf8proc 1.2 (closes JuliaLang#10654); replace …
90c0fb4 
…wcwidth by utf8proc_charwidth (fixes JuliaLang#3721, closes JuliaLang#6939)
stevengj added a commit to stevengj/julia that referenced this issue Mar 30, 2015
@stevengj
update libmojibake -> utf8proc 1.2 (closes JuliaLang#10654); replace …
95e29d2 
…wcwidth by utf8proc_charwidth (fixes JuliaLang#3721, closes JuliaLang#6939)
stevengj added a commit to stevengj/julia that referenced this issue Mar 30, 2015
@stevengj
update libmojibake -> utf8proc 1.2 (closes JuliaLang#10654); replace …
4813b29 
…wcwidth by utf8proc_charwidth (fixes JuliaLang#3721, closes JuliaLang#6939)
stevengj added a commit to stevengj/julia that referenced this issue Mar 30, 2015
@stevengj
update libmojibake -> utf8proc 1.2 (closes JuliaLang#10654); replace …
60aee18 
…wcwidth by utf8proc_charwidth (fixes JuliaLang#3721, closes JuliaLang#6939)
stevengj added a commit to stevengj/julia that referenced this issue Mar 30, 2015
@stevengj
update libmojibake -> utf8proc 1.2 (closes JuliaLang#10654); replace …
c3c0411 
…wcwidth by utf8proc_charwidth (fixes JuliaLang#3721, closes JuliaLang#6939)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain:unicode Related to unicode characters and encodings
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stevengj