-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexport thin wrapper functions around libuv? #10854
Comments
Yes please. See #1925 |
+1, not worth exporting these Some data points (not a hugely comprehensive sample, just what I happen to have installed): |
jiahao
added a commit
that referenced
this issue
Apr 18, 2015
jiahao
added a commit
that referenced
this issue
Apr 19, 2015
jiahao
added a commit
that referenced
this issue
Apr 20, 2015
Unexport the functions mentioned in #10854
Closed by #10885 |
mbauman
pushed a commit
to mbauman/julia
that referenced
this issue
Jun 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The functions
start_timer
stop_timer
start_reading
stop_reading
start_watching
are essentially thin wrappers around libuv functions of similar names and probably should be unexported.
start_watching
,stop_watching
, is unexported.start_timer
is only called bysleep
andtimedwait
.stop_timer
is only called bytimedwait
.start_timer
norstop_timer
validate their arguments, leading to possible weird errors like in start_timer: Saturate arguments to be at least zero #10847The text was updated successfully, but these errors were encountered: