Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexport thin wrapper functions around libuv? #10854

Closed
jiahao opened this issue Apr 17, 2015 · 3 comments
Closed

Unexport thin wrapper functions around libuv? #10854

jiahao opened this issue Apr 17, 2015 · 3 comments

Comments

@jiahao
Copy link
Member

jiahao commented Apr 17, 2015

The functions

  • start_timer
  • stop_timer
  • start_reading
  • stop_reading
  • start_watching

are essentially thin wrappers around libuv functions of similar names and probably should be unexported.

  1. The last three have no documentation.
  2. The counterpart to start_watching, stop_watching, is unexported.
  3. start_timer is only called by sleep and timedwait.
  4. stop_timer is only called by timedwait.
  5. Neither start_timer nor stop_timer validate their arguments, leading to possible weird errors like in start_timer: Saturate arguments to be at least zero #10847
@JeffBezanson
Copy link
Member

Yes please. See #1925

@tkelman
Copy link
Contributor

tkelman commented Apr 17, 2015

+1, not worth exporting these

Some data points (not a hugely comprehensive sample, just what I happen to have installed):
Tk and ImageView use start_timer
ImageView uses stop_timer
JSON uses start_reading

jiahao added a commit that referenced this issue Apr 20, 2015
Unexport the functions mentioned in #10854
@jiahao
Copy link
Member Author

jiahao commented Apr 20, 2015

Closed by #10885

@jiahao jiahao closed this as completed Apr 20, 2015
mbauman pushed a commit to mbauman/julia that referenced this issue Jun 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants