Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexport the functions mentioned in #10854 #10885

Merged
merged 1 commit into from
Apr 20, 2015
Merged

Unexport the functions mentioned in #10854 #10885

merged 1 commit into from
Apr 20, 2015

Conversation

jiahao
Copy link
Member

@jiahao jiahao commented Apr 18, 2015

No description provided.

@tkelman
Copy link
Contributor

tkelman commented Apr 19, 2015 

    * repl                ERROR (unhandled task failure): UndefVarError: start_reading not defined
 in prompt! at LineEdit.jl:1570
 in run_interface at LineEdit.jl:1547
 in anonymous at task.jl:35

jiahao added a commit that referenced this pull request Apr 20, 2015
@jiahao
Merge pull request #10885 from JuliaLang/cjh/fix-10854
ca26f91 
Unexport the functions mentioned in #10854
@jiahao jiahao merged commit ca26f91 into master Apr 20, 2015
@jiahao jiahao deleted the cjh/fix-10854 branch April 20, 2015 03:01
This was referenced Apr 20, 2015
Closed
Closed
@JeffBezanson
Copy link
Member

start_timer and stop_timer are not as useless as the other functions here: they are currently the only way to make a timer actually do anything, and are used in several packages. Fine with me to remove them, but then we need some other API for starting a timer. Writing Base.start_timer is not really a better interface than writing start_timer.

@jiahao
Copy link
Member Author

jiahao commented Apr 20, 2015

Should I re-export them then? My only quibble with them was that they don't validate their arguments, and throwing InexactError on negative wait periods and polling intervals is quite inscrutable for a user-facing function.

@JeffBezanson
Copy link
Member

Well, the only reason they've lasted as long as they have is that as much as I hate underscores, I haven't thought of better replacements. Until somebody proposes a better API, I think we should re-export and have them check their arguments.

jiahao added a commit that referenced this pull request Apr 20, 2015
@jiahao
Reexport start_timer, stop_timer
438e90b 
Make start_timer validate its arguments.

Ref: discussion in #10885
@tkelman
Copy link
Contributor

tkelman commented Apr 20, 2015

I think we need Base. in a few more places, I got

WARNING: Caught an exception in the keymap:
ERROR: UndefVarError: stop_reading not defined

from trying to paste something multi-line into the repl.

jiahao added a commit that referenced this pull request Apr 21, 2015
@jiahao
Fixup from #10885
9db1f8d 
Qualify more functions using stop_reading, start_reading with Base
module identifier.

Also touch up whitespace error in docs
mbauman pushed a commit to mbauman/julia that referenced this pull request Jun 6, 2015
@jiahao @mbauman
Reexport start_timer, stop_timer
eab3792 
Make start_timer validate its arguments.

Ref: discussion in JuliaLang#10885
mbauman pushed a commit to mbauman/julia that referenced this pull request Jun 6, 2015
@jiahao @mbauman
Fixup from JuliaLang#10885
f2bc28c 
Qualify more functions using stop_reading, start_reading with Base
module identifier.

Also touch up whitespace error in docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiahao @tkelman @JeffBezanson