-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
istext("I am text") returns false - rename to istextmime
#12872
Comments
Probably |
@stevengj Agreed users can easily confuse MIME types with strings |
Or just remove the convenience version accepting strings. |
@nalimilan, that would work, but you would need to add a method |
|
+1 for renaming to something involving |
istextmime
fix #12872, rename `istext` to `istextmime`
In multimedia.jl,
istext()
is intended to assess MIME types. But since theistext()
is exported, it can be taken out of context and generate counter-intuitive results. Maybe a more descriptive name would be warranted?From multimedia.jl --
The text was updated successfully, but these errors were encountered: