Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate scale #12945

Closed
andreasnoack opened this issue Sep 4, 2015 · 3 comments
Closed

Deprecate scale #12945

andreasnoack opened this issue Sep 4, 2015 · 3 comments
Labels
domain:linear algebra Linear algebra needs decision A decision on this change is needed
Milestone

Comments

@andreasnoack
Copy link
Member

When 0.4 has been tagged. I think we should deprecate the scale functions (without exclamation marks) in favor of just using multiplication. At least for scaling with a scalar, but I also would prefer A*Diagonal(x) over scale(A,x) for scaling with a vector x.

@andreasnoack andreasnoack added domain:linear algebra Linear algebra needs decision A decision on this change is needed labels Sep 4, 2015
@andreasnoack andreasnoack added this to the 0.5 milestone Sep 4, 2015
@tkelman
Copy link
Contributor

tkelman commented Sep 4, 2015

Would multiplication by a scalar get dispatched to blas, or have the same level of simd?

@stevengj
Copy link
Member

stevengj commented Sep 4, 2015

@tkelman, I don't see why it couldn't be implemented that way. I agree that scale! is useful but scale is redundant with *.

@Jutho
Copy link
Contributor

Jutho commented Sep 4, 2015

I also think it doesn't matter much whether this is handled by BLAS or by a pure Julia implementation. The dominating factor is probably memory access (and simd), but all the fancy multithreading won't help that much. At least that's the experience I had from some simple comparison a while ago, but I might certainly be misremembering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:linear algebra Linear algebra needs decision A decision on this change is needed
Projects
None yet
Development

No branches or pull requests

4 participants