Documenting methods for the same function in different modules

[andreasnoack]

There seems to be a problem with documenting the same function in different module. I think this should work in general and is important for linear algebra documentation strings where methods for the function are often defined in LinAlg and SparseMatrix. An example of the problem is

module A

export foo

doc"""
foo from A
"""
foo(::Int) = 1

end

module B

import A: foo

export foo

doc"""
foo from B
"""
foo(::Float64) = 2

end

julia> using B

julia> foo(1)
1

julia> foo(1.0)
2

help?> foo
search: foo floor ifloor pointer_from_objref OverflowError RoundFromZero FloatingPoint FileMonitor functionloc functionlocs StackOverflowError Factorization OutOfMemoryError unsafe_pointer_to_objref

  foo from A

[MichaelHatherly]

All the docs are still being captured. The problem is here where only the first module that has docs is returned. Something like the following would fix it:

diff --git a/base/docs/Docs.jl b/base/docs/Docs.jl
index f248ace..970915e 100644
--- a/base/docs/Docs.jl
+++ b/base/docs/Docs.jl
@@ -238,6 +238,7 @@ doc(f::Function) = doc(f, Tuple)

 function doc(f::Function, sig::Type)
     isgeneric(f) && isempty(methods(f,sig)) && return nothing
+    docs = []
     for mod in modules
         if (haskey(meta(mod),f) && isa(meta(mod)[f],FuncDoc))
             fd = meta(mod)[f]
@@ -250,14 +251,14 @@ function doc(f::Function, sig::Type)
             end
             # if all method signatures are Union{} ( ⊥ ), concat all docstrings
             if isempty(results)
-                return catdoc([fd.meta[msig] for msig in reverse(fd.order)]...)
+                push!(docs, catdoc([fd.meta[msig] for msig in reverse(fd.order)]...))
             else
                 sort!(results, lt=(a,b)->type_morespecific(first(a),first(b)))
-                return catdoc([last(r) for r in results]...)
+                push!(docs, catdoc([last(r) for r in results]...))
             end
         end
     end
-    return nothing
+    isempty(docs) ? nothing : catdoc(docs...)
 end
 doc(f::Function,args::Any...) = doc(f, Tuple{args...})