Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmetic fixes for LinAlg.chksquare #14601

Merged
merged 3 commits into from
Jan 9, 2016
Merged

cosmetic fixes for LinAlg.chksquare #14601

merged 3 commits into from
Jan 9, 2016

Conversation

tpapp
Copy link
Contributor

@tpapp tpapp commented Jan 8, 2016

Closes JuliaLang/LinearAlgebra.jl#292, by

  • renaming chksquare to checksquare
  • writing documentation for checksquare and putting it in the stdlib docs (without exportingit from LinAlg)
  • adding some simple tests for checksquare

tpapp added 3 commits January 8, 2016 08:22
Fixes #14388, following the suggestions there:
- new name is `checksquare`
- not exported, documents `LinAlg.checksquare` accordingly
@ViralBShah
Copy link
Member

Cc @andreasnoack

@StefanKarpinski
Copy link
Member

Didn't we want to export it too?

@tkelman
Copy link
Contributor

tkelman commented Jan 8, 2016

I didn't. This lgtm as is.

@kshyatt kshyatt added linear algebra Linear algebra docs This change adds or pertains to documentation labels Jan 8, 2016
@andreasnoack
Copy link
Member

Yes. I agree.

andreasnoack added a commit that referenced this pull request Jan 9, 2016
cosmetic fixes for `LinAlg.chksquare`
@andreasnoack andreasnoack merged commit 0a1a612 into JuliaLang:master Jan 9, 2016
ScottPJones added a commit to ScottPJones/julia that referenced this pull request Jan 17, 2016
ScottPJones added a commit to ScottPJones/julia that referenced this pull request Jan 20, 2016
ScottPJones added a commit to ScottPJones/julia that referenced this pull request Jan 21, 2016
ScottPJones added a commit to ScottPJones/julia that referenced this pull request Jan 28, 2016
ScottPJones added a commit to ScottPJones/julia that referenced this pull request Jan 29, 2016
ScottPJones added a commit to ScottPJones/julia that referenced this pull request Jan 30, 2016
ScottPJones added a commit to ScottPJones/julia that referenced this pull request Jan 30, 2016
ScottPJones added a commit to ScottPJones/julia that referenced this pull request Jan 31, 2016
ScottPJones added a commit to ScottPJones/julia that referenced this pull request Jan 31, 2016
juliohm added a commit to juliohm/GraphPlot.jl that referenced this pull request Mar 28, 2017
sbromberger pushed a commit to JuliaGraphs/GraphPlot.jl that referenced this pull request May 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

export Base.LinAlg.chksquare
6 participants