Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor promotion issue with A[t|c]_ldiv_B for triangular A and non-strided B #14816

Closed
Sacha0 opened this issue Jan 27, 2016 · 4 comments
Closed

Comments

@Sacha0
Copy link
Member

Sacha0 commented Jan 27, 2016

Tracker for the triangular case of #14506 described in #14506 (comment). Briefly, where A is a triangular matrix and B is not a StridedVecOrMat, the element-type promotion for A[t|c]_ldiv_B sometimes fails. For example

m = 10
intmat = fill(1, m, m);
ltintmat = LowerTriangular(rand(1:10, m, m));
At_ldiv_B(ltintmat, sparse(intmat))

fails with an InexactError. See #14506 for more. Best!

@Sacha0
Copy link
Member Author

Sacha0 commented Jun 16, 2016

Fixed.

@Sacha0 Sacha0 closed this as completed Jun 16, 2016
@tkelman
Copy link
Contributor

tkelman commented Jun 16, 2016

is it sufficiently tested to stay that way?

@Sacha0
Copy link
Member Author

Sacha0 commented Jun 16, 2016

Probably not. I'll have a look.

Sacha0 added a commit to Sacha0/julia that referenced this issue Jun 16, 2016
@Sacha0
Copy link
Member Author

Sacha0 commented Jun 16, 2016

I am not certain whether existing general tests cover this, so to be safe I added a specific test in #16968. Thanks!

tkelman added a commit that referenced this issue Jun 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants