Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty macro do not get a line number #15280

Closed
dhoegh opened this issue Feb 28, 2016 · 0 comments
Closed

Empty macro do not get a line number #15280

dhoegh opened this issue Feb 28, 2016 · 0 comments
Labels
bug Indicates an unexpected problem or unintended behavior compiler:lowering Syntax lowering (compiler front end, 2nd stage)

Comments

@dhoegh
Copy link
Contributor

dhoegh commented Feb 28, 2016

An empty macro do not get assigned a line number

macro macrotest(x::Int, y::Int)
    nothing
end
macro macrotest(x::Int, y::AbstractString) end

m=collect(methods(Main.(symbol("@macrotest"))))
functionloc(m[1]) # return a line number
functionloc(m[2]) # fails
JeffBezanson added a commit that referenced this issue Mar 1, 2016
@JeffBezanson
fix #15280, line numbers for empty functions and macros
fb62ac7
JeffBezanson added a commit that referenced this issue Mar 1, 2016
@JeffBezanson
fix #15280, line numbers for empty functions and macros
18fd401
JeffBezanson added a commit that referenced this issue Mar 1, 2016
@JeffBezanson
fix #15280, line numbers for empty functions and macros
7e55a08
@vtjnash vtjnash added bug Indicates an unexpected problem or unintended behavior compiler:lowering Syntax lowering (compiler front end, 2nd stage) labels Mar 8, 2016
JeffBezanson added a commit that referenced this issue Mar 22, 2016
@JeffBezanson
keep track of filenames in IR with metadata push/pop
2115b32 
- add location info to empty blocks; fixes #15280
- remove file names from `line` nodes
- emit `(meta push_loc filename)` and `(meta pop_loc)` around nested
  blocks from different files, to handle macros
- fix line number of `catch` blocks
JeffBezanson added a commit that referenced this issue Mar 22, 2016
@JeffBezanson
keep track of filenames in IR with metadata push/pop
abbed86 
- add location info to empty blocks; fixes #15280
- remove file names from non-initial `line` nodes
- emit `(meta push_loc filename)` and `(meta pop_loc)` around nested
  blocks from different files, to handle macros
- fix line number of `catch` blocks

[ci skip]
JeffBezanson added a commit that referenced this issue Mar 29, 2016
@JeffBezanson
keep track of filenames in IR with metadata push/pop
c03203d 
- add location info to empty blocks; fixes #15280
- remove file names from non-initial `line` nodes
- emit `(meta push_loc filename)` and `(meta pop_loc)` around nested
  blocks from different files, to handle macros
- fix line number of `catch` blocks

[ci skip]
JeffBezanson added a commit that referenced this issue Mar 29, 2016
@JeffBezanson
keep track of filenames in IR with metadata push/pop
45111a8 
- add location info to empty blocks; fixes #15280
- remove file names from non-initial `line` nodes
- emit `(meta push_loc filename)` and `(meta pop_loc)` around nested
  blocks from different files, to handle macros
- fix line number of `catch` blocks
JeffBezanson added a commit that referenced this issue May 12, 2016
@JeffBezanson
keep track of filenames in IR with metadata push/pop
d4d07f2 
- add location info to empty blocks; fixes #15280
- remove file names from non-initial `line` nodes
- emit `(meta push_loc filename)` and `(meta pop_loc)` around nested
  blocks from different files, to handle macros
- fix line number of `catch` blocks
JeffBezanson added a commit that referenced this issue May 12, 2016
@JeffBezanson
keep track of filenames in IR with metadata push/pop
1b55b08 
- add location info to empty blocks; fixes #15280
- remove file names from non-initial `line` nodes
- emit `(meta push_loc filename)` and `(meta pop_loc)` around nested
  blocks from different files, to handle macros
- fix line number of `catch` blocks
JeffBezanson added a commit that referenced this issue May 13, 2016
@JeffBezanson
keep track of filenames in IR with metadata push/pop
baf94c4 
- add location info to empty blocks; fixes #15280
- remove file names from non-initial `line` nodes
- emit `(meta push_loc filename)` and `(meta pop_loc)` around nested
  blocks from different files, to handle macros
- fix line number of `catch` blocks
JeffBezanson added a commit that referenced this issue May 16, 2016
@JeffBezanson
keep track of filenames in IR with metadata push/pop
92721b1 
- add location info to empty blocks; fixes #15280
- remove file names from non-initial `line` nodes
- emit `(meta push_loc filename)` and `(meta pop_loc)` around nested
  blocks from different files, to handle macros
- fix line number of `catch` blocks
JeffBezanson added a commit that referenced this issue May 16, 2016
@JeffBezanson
keep track of filenames in IR with metadata push/pop
43f3cd2 
- add location info to empty blocks; fixes #15280
- remove file names from non-initial `line` nodes
- emit `(meta push_loc filename)` and `(meta pop_loc)` around nested
  blocks from different files, to handle macros
- fix line number of `catch` blocks
tkelman pushed a commit to tkelman/julia that referenced this issue May 16, 2016
@JeffBezanson @tkelman
keep track of filenames in IR with metadata push/pop
a84c8d5 
- add location info to empty blocks; fixes JuliaLang#15280
- remove file names from non-initial `line` nodes
- emit `(meta push_loc filename)` and `(meta pop_loc)` around nested
  blocks from different files, to handle macros
- fix line number of `catch` blocks
JeffBezanson added a commit that referenced this issue May 16, 2016
@JeffBezanson
keep track of filenames in IR with metadata push/pop
268b4d7 
- add location info to empty blocks; fixes #15280
- remove file names from non-initial `line` nodes
- emit `(meta push_loc filename)` and `(meta pop_loc)` around nested
  blocks from different files, to handle macros
- fix line number of `catch` blocks
tkelman pushed a commit to tkelman/julia that referenced this issue May 17, 2016
@JeffBezanson @tkelman
keep track of filenames in IR with metadata push/pop
ab19f38 
- add location info to empty blocks; fixes JuliaLang#15280
- remove file names from non-initial `line` nodes
- emit `(meta push_loc filename)` and `(meta pop_loc)` around nested
  blocks from different files, to handle macros
- fix line number of `catch` blocks
JeffBezanson added a commit that referenced this issue May 18, 2016
@JeffBezanson
keep track of filenames in IR with metadata push/pop
40e87a0 
- add location info to empty blocks; fixes #15280
- remove file names from non-initial `line` nodes
- emit `(meta push_loc filename)` and `(meta pop_loc)` around nested
  blocks from different files, to handle macros
- fix line number of `catch` blocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior compiler:lowering Syntax lowering (compiler front end, 2nd stage)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vtjnash @dhoegh