Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@testset problems with @test_approx_eq #15477

Closed
jw3126 opened this issue Mar 13, 2016 · 2 comments
Closed

@testset problems with @test_approx_eq #15477

jw3126 opened this issue Mar 13, 2016 · 2 comments
Labels
test This change adds or pertains to unit tests

Comments

@jw3126
Copy link
Contributor

jw3126 commented Mar 13, 2016 

@testset "foo test" begin
    @test_approx_eq 1 1
end

Test Summary: |
foo test | No tests

It seems the test_approx_eq are executed however the summary is misleading.
@jw3126
Copy link
Contributor Author

jw3126 commented Mar 13, 2016

btw I find @testset really awesome!

@tkelman tkelman added the test This change adds or pertains to unit tests label Mar 13, 2016
@timholy timholy mentioned this issue Sep 15, 2016
Closed
juliangehring added a commit to juliangehring/MultipleTesting.jl that referenced this issue Dec 26, 2016
@juliangehring
Use isapprox instead of test_approx_eq_eps in testing
17ded5c 
Addresses
- [JuliaLang/julia#15477]: Gives us better
control for defining tolerance levels
- [JuliaLang/julia#4615]: Fixes test cases not
being represented in the testcase summary
@KristofferC
Copy link
Member

@test_approx_eq is now deprecated.

@benevolent0505 benevolent0505 mentioned this issue Nov 27, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@KristofferC @tkelman @jw3126