-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove repr(::UUID)
, move UUID code
#17026
Comments
Since this function is just an alias for |
More precisely, it's an alias for |
It is not the case that |
@JeffBezanson Thanks for noticing. I somehow managed to convince myself that it did not, but my REPL history shows I did not actually try. |
If anything, the |
repr(::UUID)
, move UUID code
Some of the UUID code will be needed for Pkg3, but if that itself is a package then it can have other-package dependencies that aren't all Base code. |
Making this a method of |
This is the typical place for such a method. fix #17026
This is the typical place for such a method. fix #17026
Looking at #17017, I noticed that there is room for more specialized (eg. faster) method specializations for
repr()
.The generic implementation in strings/io.jl:85 uses an
IOBuffer
, so it is probably much slower than it needs to be(especially for Strings which I think could be implemented as. The documentation demands the result must be the same asrepr(s::string) = s
)showall
, so testing should ensure that is still the case.The text was updated successfully, but these errors were encountered: