Re-enable doctests

[MichaelHatherly]

Doctests were disabled in #18588 since Documenter is a bit more strict in what is allowed to pass in a doctest. This issue is just to track their current status, I'm currently working on reactivating them ASAP. If anyone is curious enough to try them out now to see what's failing then you should be able to just run

make -C doc doctest

from the root directory. Currently you'll get a lot of errors, but from the looks of them they are mostly just whitespace issues that shouldn't be too much trouble to sort out.

[tkelman]

disabled in what way? they still run if you ask for them, and we never ran them by default

[MichaelHatherly]

Yes, they won't run each time the docs are built, so that hasn't changed really. Currently they will fail if you try to run them though, but I'd like to get them into a state where they can just be run by default whenever the docs get built.

[kshyatt]

ERROR: LoadError: UndefVarError: m not defined
 in eval_repl(::String, ::Module, ::Dict{Symbol,Any}, ::Documenter.Documents.Document, ::Documenter.Documents.Page) at /Users/kshyatt/Projects/julia/doc/deps/v0.6/Documenter/src/DocChecks.jl:191
 in doctest(::Base.Markdown.Code, ::Dict{Symbol,Any}, ::Documenter.Documents.Document, ::Documenter.Documents.Page) at /Users/kshyatt/Projects/julia/doc/deps/v0.6/Documenter/src/DocChecks.jl:134
 in walk(::Documenter.DocChecks.##1#2{Documenter.Documents.Document}, ::Dict{Symbol,Any}, ::Base.Markdown.Code) at /Users/kshyatt/Projects/julia/doc/deps/v0.6/Documenter/src/Walkers.jl:22
 in walk(::Function, ::Dict{Symbol,Any}, ::Array{Any,1}) at /Users/kshyatt/Projects/julia/doc/deps/v0.6/Documenter/src/Walkers.jl:36
 in walk(::Documenter.DocChecks.##1#2{Documenter.Documents.Document}, ::Dict{Symbol,Any}, ::Base.Markdown.MD) at /Users/kshyatt/Projects/julia/doc/deps/v0.6/Documenter/src/Walkers.jl:29
 in walk(::Function, ::Dict{Symbol,Any}, ::Array{Any,1}) at /Users/kshyatt/Projects/julia/doc/deps/v0.6/Documenter/src/Walkers.jl:36
 in walk(::Documenter.DocChecks.##1#2{Documenter.Documents.Document}, ::Dict{Symbol,Any}, ::Base.Markdown.MD) at /Users/kshyatt/Projects/julia/doc/deps/v0.6/Documenter/src/Walkers.jl:29
 in walk(::Function, ::Dict{Symbol,Any}, ::Array{Documenter.Documents.DocsNode,1}) at /Users/kshyatt/Projects/julia/doc/deps/v0.6/Documenter/src/Walkers.jl:36
 in walk(::Function, ::Dict{Symbol,Any}, ::Documenter.Documents.DocsNodes) at /Users/kshyatt/Projects/julia/doc/deps/v0.6/Documenter/src/Walkers.jl:49
 in doctest(::Documenter.Documents.Document) at /Users/kshyatt/Projects/julia/doc/deps/v0.6/Documenter/src/DocChecks.jl:115
 in runner at /Users/kshyatt/Projects/julia/doc/deps/v0.6/Documenter/src/Builder.jl:189 [inlined]
 in dispatch(::Type{Documenter.Builder.DocumentPipeline}, ::Documenter.Documents.Document) at /Users/kshyatt/Projects/julia/doc/deps/v0.6/Documenter/src/Selectors.jl:164
 in cd(::Documenter.##2#3{Documenter.Documents.Document}, ::String) at ./file.jl:69
 in #makedocs#1(::Bool, ::Array{Any,1}, ::Function) at /Users/kshyatt/Projects/julia/doc/deps/v0.6/Documenter/src/Documenter.jl:159
 in (::Documenter.#kw##makedocs)(::Array{Any,1}, ::Documenter.#makedocs) at ./<missing>:0
 in include_from_node1(::String) at ./loading.jl:532
 in include_from_node1(::String) at /Users/kshyatt/Projects/julia/usr/lib/julia/sys.dylib:?
 in include(::String) at ./sysimg.jl:14
 in include(::String) at /Users/kshyatt/Projects/julia/usr/lib/julia/sys.dylib:?
 in process_options(::Base.JLOptions) at ./client.jl:271
 in _start() at ./client.jl:335
 in _start() at /Users/kshyatt/Projects/julia/usr/lib/julia/sys.dylib:?
while loading /Users/kshyatt/Projects/julia/doc/make.jl, in expression starting on line 114
make: *** [check] Error 1

This bad boy is a bit hard to fathom. Are you seeing this too?

[MichaelHatherly]

Seems to have crept in during a rebase. I think I know the cause, will try to fix later today.

(Edit: should be fixed with pending tag v0.8.2)