Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sleep, etc. with Dates.Period types #19736

Closed
TotalVerb opened this issue Dec 28, 2016 · 2 comments
Closed

sleep, etc. with Dates.Period types #19736

TotalVerb opened this issue Dec 28, 2016 · 2 comments
Labels
dates Dates, times, and the Dates stdlib module

Comments

@TotalVerb
Copy link
Contributor

TotalVerb commented Dec 28, 2016 •
edited
Loading

It would be nice for standard library unity if this were supported:

sleep(Dates.Second(10))
sleep(Dates.Millisecond(10))

I personally have a hard time remembering whether sleep takes units of seconds or milliseconds.

The same goes for functions like timedwait.
@tkelman tkelman added the dates Dates, times, and the Dates stdlib module label Dec 28, 2016
@Shade5
Copy link
Contributor

Shade5 commented Dec 29, 2016

Will overloading the sleep function do?

Shade5 added a commit to Shade5/julia that referenced this issue Dec 29, 2016
@Shade5
types.jl: sleep with Date.Period types
e2497df 
Supports sleep(Dates.Second(10))
		 sleep(Dates.Milliesecond(10))

Closes JuliaLang#19736
Shade5 added a commit to Shade5/julia that referenced this issue Dec 29, 2016
@Shade5
types.jl: sleep with Date.Period types
4240a27 
Supports sleep(Dates.Second(10))
		 sleep(Dates.Milliesecond(10))

Closes JuliaLang#19736
@Shade5 Shade5 mentioned this issue Dec 29, 2016
Merged
@Shade5
Copy link
Contributor

Shade5 commented Dec 29, 2016

@TotalVerb Please review #19749

Shade5 added a commit to Shade5/julia that referenced this issue Dec 29, 2016
@Shade5
types.jl: sleep with Date.Period types
2e01a5b 
Supports sleep(Dates.Second(10))
		 sleep(Dates.Milliesecond(10))

Closes JuliaLang#19736
Shade5 added a commit to Shade5/julia that referenced this issue Dec 29, 2016
@Shade5
types.jl: sleep with Date.Period types
3d43a79 
Supports sleep(Dates.Second(10))
		 sleep(Dates.Milliesecond(10))

Closes JuliaLang#19736
Shade5 added a commit to Shade5/julia that referenced this issue Dec 29, 2016
@Shade5
types.jl: sleep with Date.Period types
abe3edb 
Supports sleep(Dates.Second(10))
		 sleep(Dates.Milliesecond(10))

Closes JuliaLang#19736
Shade5 added a commit to Shade5/julia that referenced this issue Dec 29, 2016
@Shade5
types.jl: sleep with Date.Period types
03a6a04 
Supports sleep(Dates.Second(10))
		 sleep(Dates.Milliesecond(10))

Closes JuliaLang#19736
Shade5 added a commit to Shade5/julia that referenced this issue Jan 1, 2017
@Shade5
types.jl: sleep with Date.Period types
861ecf0 
Supports sleep(Dates.Second(10))
		 sleep(Dates.Milliesecond(10))

Closes JuliaLang#19736
Shade5 added a commit to Shade5/julia that referenced this issue Jan 1, 2017
@Shade5
types.jl: sleep with Date.Period types
fbd4878 
Supports sleep(Dates.Second(10))
		 sleep(Dates.Milliesecond(10))

Closes JuliaLang#19736
Shade5 added a commit to Shade5/julia that referenced this issue Jan 1, 2017
@Shade5
types.jl: sleep with Date.Period types
3dd6a79 
Supports sleep(Dates.Second(10))
		 sleep(Dates.Milliesecond(10))

Closes JuliaLang#19736
Shade5 added a commit to Shade5/julia that referenced this issue Jan 2, 2017
@Shade5
types.jl: sleep with Date.Period types
4be146b 
Supports sleep(Dates.Second(10))
		 sleep(Dates.Milliesecond(10))

Closes JuliaLang#19736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dates Dates, times, and the Dates stdlib module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tkelman @TotalVerb @Shade5