Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Printing of Signature in libgit2 #22103

Closed
KristofferC opened this issue May 27, 2017 · 1 comment
Closed

Printing of Signature in libgit2 #22103

KristofferC opened this issue May 27, 2017 · 1 comment
Labels
display and printing Aesthetics and correctness of printed representations of objects. libgit2 The libgit2 library or the LibGit2 stdlib module

Comments

@KristofferC
Copy link
Member

Here: the unix time is computed as: sig.time + sig.time_offset. However, the docs for TimeStruct says: offset::Cint # timezone offset in minutes.

Should there be a *60 on the sig.time_offset in show?
@KristofferC KristofferC added the libgit2 The libgit2 library or the LibGit2 stdlib module label May 27, 2017
@kshyatt kshyatt added the display and printing Aesthetics and correctness of printed representations of objects. label May 28, 2017
@simonbyrne
Copy link
Contributor

Why don't we just print the time + offset, like command line git does?

simonbyrne added a commit that referenced this issue May 30, 2017
@simonbyrne
Fix calculation of displayed time, show UTC offset
c1d6801 
Fixes #22103.
@simonbyrne simonbyrne mentioned this issue May 30, 2017
Merged
KristofferC pushed a commit that referenced this issue Jun 1, 2017
@simonbyrne @KristofferC
Fix calculation of displayed time, show UTC offset (#22136)
8758659 
* Fix calculation of displayed time, show UTC offset

Fixes #22103.

* add space to argument
tkelman pushed a commit that referenced this issue Jun 3, 2017
@simonbyrne @tkelman
Fix calculation of displayed time, show UTC offset (#22136)
e6ffb7e 
* Fix calculation of displayed time, show UTC offset

Fixes #22103.

* add space to argument

(cherry picked from commit 8758659)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
display and printing Aesthetics and correctness of printed representations of objects. libgit2 The libgit2 library or the LibGit2 stdlib module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kshyatt @KristofferC @simonbyrne