Rename Range to AbstractRange #23570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename Range to AbstractRange, and Range1 to UnitRange (which should have been done before).
ararslan
added
domain:collections
nalimilan
force-pushed
the
nl/abstractrange
branch
from
416476e
to
afda0ea
Compare
|
OK to merge? This tends to accumulate conflicts quite fast. |
mbauman
approved these changes
Sep 7, 2017
base/abstractarray.jl
Outdated
| @@ -172,7 +172,7 @@ first(a::AbstractArray) = a[first(eachindex(a))] | |||
| first(coll) | |||
|
|
|||
| Get the first element of an iterable collection. Returns the start point of a | |||
doc/src/manual/control-flow.md
Outdated
| @@ -409,7 +409,7 @@ julia> for i = 1:5 | |||
| 5 | |||
| ``` | |||
|
|
|||
| Here the `1:5` is a `Range` object, representing the sequence of numbers 1, 2, 3, 4, 5. The `for` | |||
| Here the `1:5` is an `AbstractRange` object, representing the sequence of numbers 1, 2, 3, 4, 5. The `for` | |||
There was a problem hiding this comment.
It'd be clearer to just say it's a UnitRange or maybe even just "a range" (lowercase).
doc/src/manual/arrays.md
Outdated
| @@ -348,7 +348,7 @@ indices and can be converted to such by [`to_indices`](@ref): | |||
| 2. An array of scalar indices. This includes: | |||
| * Vectors and multidimensional arrays of integers | |||
| * Empty arrays like `[]`, which select no elements | |||
| * `Range`s of the form `a:c` or `a:b:c`, which select contiguous or strided subsections from `a` to `c` (inclusive) | |||
| * `AbstractRange`s of the form `a:c` or `a:b:c`, which select contiguous or strided subsections from `a` to `c` (inclusive) | |||
There was a problem hiding this comment.
I'd simply say: "Ranges like a:c…" Making this more jargon-y implies a distinction that doesn't exist.
|
Thanks for the review. Indeed the systematic replacement of |
Bachibouzouk
added a commit
to Bachibouzouk/Mbo.jl
that referenced
this pull request
Jul 22, 2024
-Range renamed AbstractRange JuliaLang/julia#23570 -squeeze renamed dropdims -immutable renamed struct JuliaLang/julia#20418
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21901.