-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
what to do with setrounding
?
#26935
Comments
Moving it to a package sounds reasonable. |
Basically rounding seems to be completely broken on Windows. |
(a) unexport setrounding (b) eventually favor rounding mode savvy mathops |
Earlier this year, I wrote DirectedRoundings.jl. This is a small package that intends to make making good use of directing rounding directions. The approach there lets setrounding do much of this governed crunching ... leaving to us the higher order engagements. With the apparent sidelining of reliable and portable and subtype specific setrounding, do we have any winning way waiting? |
Fixes #26935. This is the "minimal" change of deprecating Float32/Float64 support.
Fixes #26935. This is the "minimal" change of deprecating Float32/Float64 support.
I recently realised that this has negative consequences for MPFR, where the rounding is done in software and so works on any machine. Perhaps it is enough to have |
I have found MPFR (as seen through our BigFloat) to be unreliable in the last digit. Using setrounding with BigFloat may be not entirely ok. I have not done any testing on that -- I have done some to see that the last digit is not always rounded to nearest (when no other setrounding is in use). It has made verifying development code in the new Arb package difficult. |
@JeffreySarnoff do you have an example? |
@dpsanders I intentionally kept |
@simonbyrne Thanks, I just realised that |
I have no example, and no specific details. I was testing some extended precision trig or arctrig functions and using BigFloat values for comparison -- one test failed and I tracked it back to BigFloat's value after redoing the work in Maple. At the time, frustration and recordkeeping/filesaving were at odds. The only detail I recall is 3 days of yuck. |
Although marked as experimental in the docs, it still triggers a lot of issues (#17926, #26801, #26934). Perhaps we should unexport it, or deprecate it all together (functionality could be moved to a package).
cc: @dpsanders
The text was updated successfully, but these errors were encountered: