Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab completion of symbols fails when doing using Package: Foo #29275

Closed
KristofferC opened this issue Sep 20, 2018 · 4 comments · Fixed by #54610
Closed

Tab completion of symbols fails when doing using Package: Foo #29275

KristofferC opened this issue Sep 20, 2018 · 4 comments · Fixed by #54610
Labels
stdlib:REPL Julia's REPL (Read Eval Print Loop)

Comments

@KristofferC
Copy link
Sponsor Member

For example:

julia> using LibGit2: GitRepo

julia> GitR<TAB> # doesn't complete

julia> using LibGit2

julia> GitR<TAB> # completes to GitRepo

This also fails on 0.6 but according to @ararslan it works on 0.5 so marking as regression.
@KristofferC KristofferC added kind:bug Indicates an unexpected problem or unintended behavior stdlib:REPL Julia's REPL (Read Eval Print Loop) kind:regression Regression in behavior compared to a previous version labels Sep 20, 2018
@KristofferC
Copy link
Sponsor Member Author

KristofferC commented Sep 20, 2018 •
edited
Loading

Is there any way to find out about the existence of the GitRepo binding programmatically after using using LibGit2: GitRepo?

@stevengj
Copy link
Member

stevengj commented Sep 20, 2018 •
edited
Loading

:GitRepo in names(Main, all=true, imported=true) returns false after using LibGit2: GitRepo. If you do import LibGit2: GitRepo then tab-completion works.

@KristofferC
Copy link
Sponsor Member Author

Yeah, you mean that that's the bug?

@stevengj
Copy link
Member

stevengj commented Sep 20, 2018 •
edited
Loading

Seems like it's related, since I think tab completion uses names? If I type using LibGit2 then LibGit2 shows up in names(Main, all=true, imported=true) and works with tab completion.

@vtjnash vtjnash mentioned this issue Mar 30, 2021
Open
@vtjnash vtjnash removed kind:bug Indicates an unexpected problem or unintended behavior kind:regression Regression in behavior compared to a previous version labels Aug 24, 2023
@aviatesk aviatesk mentioned this issue May 29, 2024
Merged
aviatesk added a commit that referenced this issue May 31, 2024
@aviatesk
REPLCompletions: allow completions for explicitly using-ed names
9c307ff 
The new feature `usings=true` added to `names` enhances REPL completions
by allowing explicitly `using`-ed names to be found.
```julia
julia> using Base: @assume_effects

julia> @assu| # completes to `@assume_effects`
```

As a result, the implementation of REPL completions has been simplified.
Additionally, it allows completion for names that are implicitly or
explicitly `using`-ed in code specifying a module explicitly, such as:
```julia
julia> module A end

julia> A.signi| # completes to `A.significand`
```

- fixes #29275
- fixes #40356
- fixes #49109
- fixes #53524
aviatesk added a commit that referenced this issue May 31, 2024
@aviatesk
REPLCompletions: allow completions for explicitly using-ed names (#…
8d3b905 
…54610)

The new feature `usings=true` added to `names` enhances REPL completions
by allowing explicitly `using`-ed names to be found.
```julia
julia> using Base: @assume_effects

julia> @assu| # completes to `@assume_effects`
```

As a result, the implementation of REPL completions has been simplified.
Additionally, it allows completion for names that are implicitly or
explicitly `using`-ed in code specifying a module explicitly, such as:
```julia
julia> module A end

julia> A.signi| # completes to `A.significand`
```

- fixes #29275
- fixes #40356
- fixes #49109
- fixes #53524
lazarusA pushed a commit to lazarusA/julia that referenced this issue Jul 12, 2024
@aviatesk @lazarusA
REPLCompletions: allow completions for explicitly using-ed names (J…
465e0df 
…uliaLang#54610)

The new feature `usings=true` added to `names` enhances REPL completions
by allowing explicitly `using`-ed names to be found.
```julia
julia> using Base: @assume_effects

julia> @assu| # completes to `@assume_effects`
```

As a result, the implementation of REPL completions has been simplified.
Additionally, it allows completion for names that are implicitly or
explicitly `using`-ed in code specifying a module explicitly, such as:
```julia
julia> module A end

julia> A.signi| # completes to `A.significand`
```

- fixes JuliaLang#29275
- fixes JuliaLang#40356
- fixes JuliaLang#49109
- fixes JuliaLang#53524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stdlib:REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

REPLCompletions: allow completions for explicitly using-ed names JuliaLang/julia
3 participants
@vtjnash @KristofferC @stevengj