Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete curried comparisons #30915

Merged
merged 2 commits into from
Feb 2, 2019
Merged

complete curried comparisons #30915

merged 2 commits into from
Feb 2, 2019

Conversation

JeffreySarnoff
Copy link
Contributor

added !=(x) >=(x) <=(x) <(x) >(x) with docs and tests

@ararslan ararslan requested a review from JeffBezanson January 31, 2019 17:10
@ararslan ararslan added the needs news A NEWS entry is required for this change label Jan 31, 2019
@JeffreySarnoff
Copy link
Contributor Author

Here is the line for News.md (I do not have a local copy of julia to push -- just my fork, so pls insert or explain how to do that from github directly).

  • All comparison ops can now be used in curried form: ==(x), !=(x), >(x), >=(x), <(x), <=(x).

Copy link
Member

@andyferris andyferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I’ve definitely missed these.

@StefanKarpinski StefanKarpinski merged commit e7e726b into JuliaLang:master Feb 2, 2019
@fredrikekre fredrikekre added the needs compat annotation Add !!! compat "Julia x.y" to the docstring label Feb 5, 2019
fredrikekre added a commit that referenced this pull request Feb 6, 2019
fredrikekre added a commit that referenced this pull request Feb 6, 2019
@fredrikekre fredrikekre mentioned this pull request Feb 6, 2019
@fredrikekre fredrikekre removed needs compat annotation Add !!! compat "Julia x.y" to the docstring needs news A NEWS entry is required for this change labels Feb 6, 2019
fredrikekre added a commit that referenced this pull request Feb 6, 2019
compat annotations, news and manual updates for #29790, #30496 and #30915.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants