Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hasproperty and hasfield to Base RFC #30496

Merged
merged 10 commits into from
Feb 5, 2019
Merged

Add hasproperty and hasfield to Base RFC #30496

merged 10 commits into from
Feb 5, 2019

Conversation

sam0410
Copy link
Contributor

@sam0410 sam0410 commented Dec 23, 2018

Fixes #28850

stevengj
stevengj reviewed Dec 24, 2018
View reviewed changes
base/reflection.jl Outdated Show resolved Hide resolved
stevengj
stevengj reviewed Dec 24, 2018
View reviewed changes
base/reflection.jl Outdated Show resolved Hide resolved
stevengj
stevengj reviewed Dec 24, 2018
View reviewed changes
base/reflection.jl Outdated Show resolved Hide resolved
@KristofferC KristofferC added the needs news A NEWS entry is required for this change label Dec 25, 2018
@iamed2
Copy link
Contributor

iamed2 commented Dec 26, 2018

Supersedes #27582 I guess

@iamed2 iamed2 mentioned this pull request Dec 26, 2018
Closed
@sam0410
Copy link
Contributor Author

sam0410 commented Dec 26, 2018 •
edited
Loading

Oh! Didn't know that one existed. Thanks for closing it @iamed2

@sam0410 sam0410 changed the title Add hasproperty and hasfield to Base Add hasproperty and hasfield to Base WIP Dec 26, 2018
stevengj
stevengj reviewed Dec 31, 2018
View reviewed changes
base/reflection.jl Outdated Show resolved Hide resolved
@sam0410
Copy link
Contributor Author

sam0410 commented Jan 9, 2019

Thanks for the review @stevengj . I resolved your comments. Is this PR ready to be merged now?

@sam0410 sam0410 changed the title Add hasproperty and hasfield to Base WIP Add hasproperty and hasfield to Base RFC Jan 21, 2019
@sam0410
Copy link
Contributor Author

sam0410 commented Feb 3, 2019

Hi @stevengj , I just came here to check if this is ready to be merged. Thanks.

@stevengj
Copy link
Member

stevengj commented Feb 4, 2019

LGTM.

@StefanKarpinski StefanKarpinski merged commit 9f66185 into JuliaLang:master Feb 5, 2019
@tkf tkf mentioned this pull request Feb 5, 2019
Merged
@fredrikekre fredrikekre added the needs compat annotation Add !!! compat "Julia x.y" to the docstring label Feb 5, 2019
@sam0410 sam0410 deleted the unn branch February 6, 2019 10:48
fredrikekre added a commit that referenced this pull request Feb 6, 2019
@fredrikekre
doc: compat annotations, news and manual updates
020963a 
for #29790, #30496 and #30915.
fredrikekre added a commit that referenced this pull request Feb 6, 2019
@fredrikekre
doc: compat annotations, news and manual updates
7bd0fc7 
for #29790, #30496 and #30915.
@fredrikekre fredrikekre mentioned this pull request Feb 6, 2019
Merged
@fredrikekre fredrikekre removed needs compat annotation Add !!! compat "Julia x.y" to the docstring needs news A NEWS entry is required for this change labels Feb 6, 2019
fredrikekre added a commit that referenced this pull request Feb 6, 2019
@fredrikekre
doc: misc updates (#30977)
94548eb 
compat annotations, news and manual updates for #29790, #30496 and #30915.
@homocomputeris homocomputeris mentioned this pull request May 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyferris andyferris andyferris left review comments

@ararslan ararslan ararslan left review comments

@stevengj stevengj stevengj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sam0410 @iamed2 @stevengj @andyferris @ararslan @StefanKarpinski @KristofferC @fredrikekre