Add zero for TimeType #35554
Merged
Add zero for TimeType #35554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add zero for `TimeType` (according to the docs, zero `Gets the additive identity element for the type of x (x can also specify the type itself)`).
dkarrasch
reviewed
Apr 23, 2020
nickrobinson251
added a commit
to JuliaDiff/ChainRulesCore.jl
that referenced
this pull request
Apr 27, 2020
- following JuliaLang/julia#35554 which agrees with the point made here, but shows the given code to be misleading.
nickrobinson251
added a commit
to JuliaDiff/ChainRulesCore.jl
that referenced
this pull request
Apr 27, 2020
- following JuliaLang/julia#35554 which agrees with the point made here, but shows the given code to be misleading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to docs, zero "gets the additive identity element for the type of x (x can also specify the
type itself).". Defining this method allows one to get the type of
dt::T - dt::Tin a generic way.