-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
”contrib/julia.svg" has different color scheme and layout from other resources #35568
Comments
The contrib/julia.svg image is definitely off here: the colors are off, the placement of the dots is off. It should either be deleted or replaced with an SVG that matches julia-logo-graphics. Unclear if the file used for anything? cc @ViralBShah |
😰I’m very sorry, I must have committed the wrong version (too many files with the same name floating around combined with my poor git skills). |
The contrib file should just be deleted. |
In fact |
No worries, @cormullion! Just good to get it sorted out. |
As discussed in #35568. Logos should be used from the official logos repo.
Although we should clean the table, this problem is resolved, and the PR in Colors.jl can also be resolved. Thanks! |
The Julia logo was updated about a year ago.
Round 1 (JuliaLang/www.julialang.org#372)
https://github.com/JuliaLang/www.julialang.org/blob/9c2ffde0233da26f7d5f1e07408823825860d46b/_includes/logo.svg
Round 2 (#32038)
https://github.com/JuliaLang/julia/blob/b5a4601bbe8a6f1b8ce8f4e307543850c08adb8e/contrib/julia.svg
Although there are some differences in numerical representation, the round 1 logo uses the color scheme defined in julia-logo-graphics.
However, the round 2 logo(i.e. julia.svg in this repository), has a slightly different color scheme. (see the "blue" dot.)
WRT the layout, I can not exactly make sure the original intent, but WRT the color schemes, "contrib/julia.svg" is different from the original intent.
The original discussion: JuliaGraphics/Colors.jl#418
cc: @cormullion
The text was updated successfully, but these errors were encountered: