Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

differing semantics amongst success()'s #3962

Closed
nlhepler opened this issue Aug 6, 2013 · 2 comments
Closed

differing semantics amongst success()'s #3962

nlhepler opened this issue Aug 6, 2013 · 2 comments

Comments

@nlhepler
Copy link
Contributor

nlhepler commented Aug 6, 2013

success() for ::Process, ::ProcessChain, and ::Vector{Process} all just check the exit code (without waiting), but success() for ::AbstractCmd does a wait_success().

Also, we seem to be missing a wait() for ::ProcessChain, which seems reasonable because the current wait semantics (return the exit code) aren't well defined for this type, but it seems then that the semantics are suboptimal. Lacking this, it's very difficult to wait on a ProcessChain before checking for success.
@nlhepler
Copy link
Contributor Author

nlhepler commented Aug 7, 2013

The last bit is a dup of #3846.

@JeffBezanson
Copy link
Member

Now success always waits.

KristofferC pushed a commit that referenced this issue Jul 26, 2024
@DilumAluthgeBot @DilumAluthge
🤖 [master] Bump the Pkg stdlib from 6b4394914 to e4a6723bf (#55258)
5650a13 
Stdlib: Pkg
URL: https://github.com/JuliaLang/Pkg.jl.git
Stdlib branch: master
Julia branch: master
Old commit: 6b4394914
New commit: e4a6723bf
Julia version: 1.12.0-DEV
Pkg version: 1.12.0
Bump invoked by: @IanButterworth
Powered by:
[BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)

Diff:
JuliaLang/Pkg.jl@6b43949...e4a6723

```
$ git log --oneline 6b4394914..e4a6723bf
e4a6723bf Use `Base.TOML.Parser{Dates}` for TOML parsing w/ Dates support (#3938)
8c1f45d98 Append bundled depots to places where we empty it during tests (#3807)
2fdfabaf5 Test fixes (#3972)
34bb51ece fix bad depot path setting (#3971)
3715685b9 fix suggestions threshold for printing (#3968)
3f81d6c4d feat: add JULIA_PKG_GC_AUTO env var (#3642)
fad26d7f2 check `project_file` isa String (#3967)
8875120ad fix not hardcoding "Project.toml" when fixing up extensions in manifest (#3851)
90d42a1b0 Make manifest usage log errors non-fatal (#3962)
```

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
lazarusA pushed a commit to lazarusA/julia that referenced this issue Aug 17, 2024
@DilumAluthgeBot @DilumAluthge @lazarusA
🤖 [master] Bump the Pkg stdlib from 6b4394914 to e4a6723bf (JuliaLang…
fae137a 
…#55258)

Stdlib: Pkg
URL: https://github.com/JuliaLang/Pkg.jl.git
Stdlib branch: master
Julia branch: master
Old commit: 6b4394914
New commit: e4a6723bf
Julia version: 1.12.0-DEV
Pkg version: 1.12.0
Bump invoked by: @IanButterworth
Powered by:
[BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)

Diff:
JuliaLang/Pkg.jl@6b43949...e4a6723

```
$ git log --oneline 6b4394914..e4a6723bf
e4a6723bf Use `Base.TOML.Parser{Dates}` for TOML parsing w/ Dates support (JuliaLang#3938)
8c1f45d98 Append bundled depots to places where we empty it during tests (JuliaLang#3807)
2fdfabaf5 Test fixes (JuliaLang#3972)
34bb51ece fix bad depot path setting (JuliaLang#3971)
3715685b9 fix suggestions threshold for printing (JuliaLang#3968)
3f81d6c4d feat: add JULIA_PKG_GC_AUTO env var (JuliaLang#3642)
fad26d7f2 check `project_file` isa String (JuliaLang#3967)
8875120ad fix not hardcoding "Project.toml" when fixing up extensions in manifest (JuliaLang#3851)
90d42a1b0 Make manifest usage log errors non-fatal (JuliaLang#3962)
```

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nlhepler @JeffBezanson