Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

digits function is little-endian #3986

Closed
vtjnash opened this issue Aug 8, 2013 · 2 comments
Closed

digits function is little-endian #3986

vtjnash opened this issue Aug 8, 2013 · 2 comments
Labels
kind:breaking This change will break code needs decision A decision on this change is needed

Comments

@vtjnash
Copy link
Sponsor Member

vtjnash commented Aug 8, 2013

Shouldn't this be reversed?

julia> digits(12345)'
1x5 Int64 Array:
 5  4  3  2  1
@quinnj
Copy link
Member

quinnj commented Aug 8, 2013

See here: 0d22e92

@stevengj
Copy link
Member

stevengj commented Aug 8, 2013

I agree with @JeffBezanson that littleendian order is probably correct. In the same way that it is nice to store a polynomial p(z) as an array p[i] of coefficients for z^(i-1). (Matlab's roots function does it backwards and it always annoyed me).

Basically, ease of utilization should take precedence over display here.

IanButterworth pushed a commit that referenced this issue Aug 9, 2024
@DilumAluthgeBot @DilumAluthge
🤖 [backports-release-1.10] Bump the Pkg stdlib from 9cb6d35f8 to 4552…
b4b1646 
…1a6e8 (#55437)

Stdlib: Pkg
URL: https://github.com/JuliaLang/Pkg.jl.git
Stdlib branch: release-1.10
Julia branch: backports-release-1.10
Old commit: 9cb6d35f8
New commit: 45521a6e8
Julia version: 1.10.4
Pkg version: 1.10.0(Does not match)
Bump invoked by: @IanButterworth
Powered by:
[BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)

Diff:
JuliaLang/Pkg.jl@9cb6d35...45521a6

```
$ git log --oneline 9cb6d35f8..45521a6e8
45521a6e8 backport extension dependency modeling from Base 1.11 to Pkg 1.10 (#3986)
1810b1123 don't swallow internal errors (#3987)
```

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:breaking This change will break code needs decision A decision on this change is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vtjnash @JeffBezanson @quinnj @stevengj