Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@vectorize_2arg should use broadcast #4363

Closed
stevengj opened this issue Sep 25, 2013 · 4 comments
Closed

@vectorize_2arg should use broadcast #4363

stevengj opened this issue Sep 25, 2013 · 4 comments

Comments

@stevengj
Copy link
Member

It seems like the @vectorize_2arg macro should really be broadcasting.

e.g. I expected this to work and be equivalent to broadcast(atan2, y, x):

y = linspace(-1,1,50)
x = y'
theta = atan2(y, x)

but it gives ERROR: argument dimensions must match.

@ViralBShah
Copy link
Member

Ah yes, those functions were written much before the broadcasting implementation.

+1

@ViralBShah
Copy link
Member

This didn't get closed for some reason from the github comment, it seems. Closing it.

@ViralBShah
Copy link
Member

Oops - that is on a branch. I see the incorrect result type issue is still open, which is holding this.

@omus
Copy link
Member

omus commented Nov 10, 2016

Looks like this should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants