-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@vectorize_2arg should use broadcast #4363
Comments
Ah yes, those functions were written much before the broadcasting implementation. +1 |
This didn't get closed for some reason from the github comment, it seems. Closing it. |
Oops - that is on a branch. I see the incorrect result type issue is still open, which is holding this. |
Merged
4 tasks
Looks like this should be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems like the
@vectorize_2arg
macro should really be broadcasting.e.g. I expected this to work and be equivalent to
broadcast(atan2, y, x)
:but it gives
ERROR: argument dimensions must match
.The text was updated successfully, but these errors were encountered: