Base.Filesystem.TEMP_CLEANUP not empty after generating sysimage

[vtjnash]

$ julia-1.6.4  -E 'Base.Filesystem.TEMP_CLEANUP'
Dict{String, Bool}("/tmp/jl_yLYZab" => 0, "/tmp/jl_MkvBa2" => 0)
$ julia-1.6.4  -E 'Base.Filesystem.TEMP_CLEANUP'
Dict{String, Bool}("/tmp/jl_yLYZab" => 0, "/tmp/jl_MkvBa2" => 0)
$ julia-1.6.4  -E 'Base.Filesystem.TEMP_CLEANUP'
Dict{String, Bool}("/tmp/jl_yLYZab" => 0, "/tmp/jl_MkvBa2" => 0)
$ ./julia -q -E 'Base.Filesystem.TEMP_CLEANUP'
Dict{String, Bool}("/var/folders/r7/k49rwnbx0w15d55pw31jlrrr0000gn/T/jl_2StMMx/jl_pn2QMwQbLq" => 0, "/var/folders/r7/k49rwnbx0w15d55pw31jlrrr0000gn/T/jl_2StMMx/jl_9WqJ99NSqZ" => 0)
$ ./julia -q -E 'Base.Filesystem.TEMP_CLEANUP'
Dict{String, Bool}("/var/folders/r7/k49rwnbx0w15d55pw31jlrrr0000gn/T/jl_2StMMx/jl_pn2QMwQbLq" => 0, "/var/folders/r7/k49rwnbx0w15d55pw31jlrrr0000gn/T/jl_2StMMx/jl_9WqJ99NSqZ" => 0)
$ ./julia -q -E 'Base.Filesystem.TEMP_CLEANUP'
Dict{String, Bool}("/var/folders/r7/k49rwnbx0w15d55pw31jlrrr0000gn/T/jl_2StMMx/jl_pn2QMwQbLq" => 0, "/var/folders/r7/k49rwnbx0w15d55pw31jlrrr0000gn/T/jl_2StMMx/jl_9WqJ99NSqZ" => 0)
$ ./julia -e 'using InteractiveUtils; versioninfo()'
Julia Version 1.8.0-DEV.1238
Commit 45faa5c59c* (2022-01-07 04:26 UTC)
Platform Info:
  OS: macOS (x86_64-apple-darwin21.1.0)
  CPU: Intel(R) Core(TM) i7-8559U CPU @ 2.70GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.0 (ORCJIT, skylake)

(since 1.6, including 1.7, and master)

[martinholters]

These paths seem to be left over in the sysimg from:

julia/contrib/generate_precompile.jl

Lines 257 to 258 in 13b3e77

	tmp_prec = tempname(prec_path)
	tmp_proc = tempname(prec_path)

Possible simple fix:

diff --git a/contrib/generate_precompile.jl b/contrib/generate_precompile.jl
index 00bbdc2652..b89265ef62 100644
--- a/contrib/generate_precompile.jl
+++ b/contrib/generate_precompile.jl
@@ -430,4 +430,5 @@ empty!(Base.ARGS)
 empty!(Core.ARGS)
 
 end # @eval
+Base.Filesystem.temp_cleanup_purge(force=true)
 end

Or would that have any downsides?

[KristofferC]

How about just having the delete! in

julia/base/file.jl

Line 548 in 13b3e77

!ispath(path) && delete!(TEMP_CLEANUP, path)

execute unconditionally?

[martinholters]

AFAICT that line is never invoked for the paths in question before the system image is written, so modifying it is unlikely to help.

[KristofferC]

I would have thought that the atexit_hooks would still run. Guess I will just try it out :)

Edit: You seem to be right, even though the atexit hook run, it is too late.