Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpaqueClosure precompilation test generates warnings in debug builds #44328

Closed
timholy opened this issue Feb 24, 2022 · 0 comments
Closed

OpaqueClosure precompilation test generates warnings in debug builds #44328

timholy opened this issue Feb 24, 2022 · 0 comments
Assignees
@Keno
Milestone
1.8

Comments

@timholy
Copy link
Member

timholy commented Feb 24, 2022

In a debug build, make debug test-precompile generates the following warnings:

WARNING: Encountered invalid lowered code for method Tuple: Core.Compiler.InvalidCodeError(kind="method signature does not match number of method arguments", meta=(false, 1, 2))
WARNING: Encountered invalid inferred code for method Tuple: Core.Compiler.InvalidCodeError(kind="method signature does not match number of method arguments", meta=(false, 1, 2))
WARNING: Encountered invalid optimized code for method Tuple: Core.Compiler.InvalidCodeError(kind="method signature does not match number of method arguments", meta=(false, 1, 2))
WARNING: Encountered invalid lowered code for method Tuple: Core.Compiler.InvalidCodeError(kind="method signature does not match number of method arguments", meta=(false, 1, 2))
WARNING: Encountered invalid inferred code for method Tuple: Core.Compiler.InvalidCodeError(kind="method signature does not match number of method arguments", meta=(false, 1, 2))
WARNING: Encountered invalid optimized code for method Tuple: Core.Compiler.InvalidCodeError(kind="method signature does not match number of method arguments", meta=(false, 1, 2))

This comes from

julia/test/precompile.jl

Line 1222 in df81bf9

@test Base.invokelatest(f, 1)(2) == 3

in the test harness that uses @opaque.
@timholy timholy mentioned this issue Feb 24, 2022
Merged
47 tasks
@KristofferC KristofferC added this to the 1.8 milestone Feb 24, 2022
simeonschaub added a commit that referenced this issue Feb 24, 2022
@simeonschaub
fix #44328: method validation for opaque closures
5cf441b 
I believe it's intentional that for these methods, the `sig` field is
just ignored and always set to `Tuple`. Also fixes a lowering bug I
discovered that would cause errors if `Union` was shadowed.

I have verified that this fixes the reported warnings.
simeonschaub added a commit that referenced this issue Feb 24, 2022
@simeonschaub
fix #44328: method validation for opaque closures
cff47d5 
I believe it's intentional that for these methods, the `sig` field is
just ignored and always set to `Tuple`. Also fixes a lowering bug I
discovered that would cause errors if `Union` was shadowed.

I have verified that this fixes the reported warnings.
staticfloat pushed a commit to JuliaCI/julia-buildkite-testing that referenced this issue Mar 2, 2022
@simeonschaub @vtjnash @staticfloat
fix JuliaLang#44328: method validation for opaque closures (JuliaLang…
aed41cf 
…#44335)

I believe it's intentional that for these methods, the `sig` field is
just ignored and always set to `Tuple`. Also fixes a lowering bug I
discovered that would cause errors if `Union` was shadowed.

I have verified that this fixes the reported warnings.

Co-authored-by: Jameson Nash <vtjnash@gmail.com>
KristofferC pushed a commit that referenced this issue Mar 3, 2022
@simeonschaub
fix #44328: method validation for opaque closures (#44335)
5db0041 
I believe it's intentional that for these methods, the `sig` field is
just ignored and always set to `Tuple`. Also fixes a lowering bug I
discovered that would cause errors if `Union` was shadowed.

I have verified that this fixes the reported warnings.

Co-authored-by: Jameson Nash <vtjnash@gmail.com>
(cherry picked from commit 5deb503)
KristofferC pushed a commit that referenced this issue Mar 7, 2022
@simeonschaub @KristofferC
fix #44328: method validation for opaque closures (#44335)
bfaabce 
I believe it's intentional that for these methods, the `sig` field is
just ignored and always set to `Tuple`. Also fixes a lowering bug I
discovered that would cause errors if `Union` was shadowed.

I have verified that this fixes the reported warnings.

Co-authored-by: Jameson Nash <vtjnash@gmail.com>
(cherry picked from commit 5deb503)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Keno Keno

Labels
None yet
Projects
None yet
Milestone
1.8
Development

No branches or pull requests
3 participants
@KristofferC @Keno @timholy