Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename CharString -> UTF32String? #4943

Closed
stevengj opened this issue Nov 26, 2013 · 1 comment
Closed

rename CharString -> UTF32String? #4943

stevengj opened this issue Nov 26, 2013 · 1 comment

Comments

@stevengj
Copy link
Member

I find it confusing that we have ASCIIString, UTF8String, and UTF16String, but we don't have UTF32String.

Can we just rename CharString?
@StefanKarpinski
Copy link
Member

That's not a bad idea.

@stevengj stevengj mentioned this issue Nov 26, 2013
Merged
JeffBezanson added a commit that referenced this issue Nov 27, 2013
@JeffBezanson
Merge pull request #4946 from stevengj/utf32
532f639 
rename CharString -> UTF32String (fix #4943)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@StefanKarpinski @stevengj