-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to append!
inconpatible with TypedTables.jl
#49748
Comments
aviatesk
added a commit
that referenced
this issue
May 11, 2023
#47154 mistakenly added `@_safeindex` macro on the `_append!(a::AbstractVector, ::Union{HasLength,HasShape}, iter)` method, although `@_safeindex` is only valid for builtin vectors i.e. `Vector`. This commit adds `isa` check so that `@_safeindex` is only applied to builtin vectors. The `isa` check should be removed at compile time, so it should not affect the runtime performance. closes #49748
Thanks for your report. Submitted a fix at #49754. |
aviatesk
added a commit
that referenced
this issue
May 12, 2023
#47154 mistakenly added `@_safeindex` macro on the `_append!(a::AbstractVector, ::Union{HasLength,HasShape}, iter)` method, although `@_safeindex` is only valid for builtin vectors i.e. `Vector`. This commit adds `isa` check so that `@_safeindex` is only applied to builtin vectors. The `isa` check should be removed at compile time, so it should not affect the runtime performance. closes #49748
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems that this commit a20a3d0 (cc @aviatesk) makes
append!
no longer work with TypedTables.jlwhereas on earlier versions that worked:
The text was updated successfully, but these errors were encountered: