Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback Logger used during startup.jl #51493

Closed
IanButterworth opened this issue Sep 28, 2023 · 1 comment · Fixed by #54428
Closed

Fallback Logger used during startup.jl #51493

IanButterworth opened this issue Sep 28, 2023 · 1 comment · Fixed by #54428
Labels
stdlib Julia's standard library
Milestone
1.11

Comments

@IanButterworth
Copy link
Member

IanButterworth commented Sep 28, 2023 •
edited
Loading

I guess removing REPL from the sysimage has caused the logger that's loaded during startup.jl to appear to be the fallback logger.
Note no color and the source line under info, which usually doesn't show.

Screenshot 2023-09-28 at 12 10 45 PM
@IanButterworth IanButterworth added the stdlib Julia's standard library label Sep 28, 2023
@vchuravy vchuravy added this to the 1.11 milestone Sep 28, 2023
@IanButterworth IanButterworth mentioned this issue Nov 8, 2023
Closed
@IanButterworth IanButterworth mentioned this issue Feb 13, 2024
Closed
@JeffBezanson
Copy link
Member

If we want the nice logger available all the time, we need to move ConsoleLogger to Base, but it depends on StyledStrings, so StyledStrings needs to be in base. Checkmate, I lose 🤷

But, maybe all we need to do is put Logging in the sysimage by default, that would be enough to fix this.

JeffBezanson added a commit that referenced this issue Mar 8, 2024
@JeffBezanson
put Logging back in default sysimage
40c79bf 
fixes #51493, fixes #52075
@JeffBezanson JeffBezanson mentioned this issue Mar 8, 2024
Closed
@KristofferC KristofferC mentioned this issue May 10, 2024
Merged
KristofferC added a commit that referenced this issue May 13, 2024
@KristofferC
Move ConsoleLogging.jl into Base (#54428)
8742d3c 
Fixes #51493, fixes
#52075
KristofferC added a commit that referenced this issue May 22, 2024
@KristofferC
Move ConsoleLogging.jl into Base (#54428)
bb67376 
Fixes #51493, fixes
#52075

(cherry picked from commit 8742d3c)
KristofferC added a commit that referenced this issue May 23, 2024
@KristofferC
Move ConsoleLogging.jl into Base (#54428)
480dfab 
Fixes #51493, fixes
#52075

(cherry picked from commit 8742d3c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stdlib Julia's standard library
Projects
None yet
Milestone
1.11
3 participants
@vchuravy @JeffBezanson @IanButterworth