Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InteractiveUtils test sometimes causes CI failure #52216

Closed
LilithHafner opened this issue Nov 17, 2023 · 4 comments
Closed

InteractiveUtils test sometimes causes CI failure #52216

LilithHafner opened this issue Nov 17, 2023 · 4 comments
Labels
ci Continuous integration test This change adds or pertains to unit tests

Comments

@LilithHafner
Copy link
Member

Recent CI failure

Error in testset InteractiveUtils:
--
  | Test Failed at /cache/build/tester-amdci4-13/julialang/julia-master/julia-234a7586c3/share/julia/stdlib/v1.11/InteractiveUtils/test/runtests.jl:232
  | Expression: #= /cache/build/tester-amdci4-13/julialang/julia-master/julia-234a7586c3/share/julia/stdlib/v1.11/InteractiveUtils/test/runtests.jl:232 =# @allocated(varinfo(Tmp14173)) < if MEMDEBUG
  | 300000
  | else
  | 100000
  | end
  | Evaluated: 100352 < 100000

Test added in #36107 cc @vtjnash

Fails intermittently and only on x86_64-linux-gnuassertrr

@LilithHafner LilithHafner added bug Indicates an unexpected problem or unintended behavior ci Continuous integration labels Nov 17, 2023
@LilithHafner LilithHafner changed the title InteractiveUtils sometimes causes CI failure InteractiveUtils test sometimes causes CI failure Nov 17, 2023
@vtjnash
Copy link
Member

vtjnash commented Nov 17, 2023

I thought I just increased the allowable allocs there, but anyways, we should just increase it by 50% again

@vtjnash vtjnash added the test This change adds or pertains to unit tests label Nov 17, 2023
@Zentrik
Copy link
Member

Zentrik commented Nov 18, 2023

This test behaves in a weird way as the reported number of allocations seems to depends on whether the test uses a < or a ==.

@LilithHafner
Copy link
Member Author

If the response to a test failure is to increase the limit, should we just remove the limit?

@vtjnash
Copy link
Member

vtjnash commented Nov 18, 2023

The limit is to measure that it is not significantly unbounded memory relative to the thing it is measuring. As the measured thing grows, sometimes we need to increase the test

@KristofferC KristofferC removed the bug Indicates an unexpected problem or unintended behavior label Nov 20, 2023
ViralBShah added a commit that referenced this issue Nov 22, 2023
@Keno Keno closed this as completed in 1b40e91 Nov 22, 2023
mkitti pushed a commit to mkitti/julia that referenced this issue Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration test This change adds or pertains to unit tests
Projects
None yet
Development

No branches or pull requests

4 participants