Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Puzzling namespace-less help message for an unexported binding #52472

Closed
jishnub opened this issue Dec 10, 2023 · 1 comment · Fixed by #52524
Closed

Puzzling namespace-less help message for an unexported binding #52472

jishnub opened this issue Dec 10, 2023 · 1 comment · Fixed by #52524
Labels
REPL Julia's REPL (Read Eval Print Loop)

Comments

@jishnub
Copy link
Contributor

jishnub commented Dec 10, 2023 

help?> IteratorSize
search: IteratorSize Iterators IteratorEltype iterate

Couldn't find IteratorSize
Perhaps you meant IteratorSize or Iterators
  No documentation found.

  Binding IteratorSize does not exist.

The suggestion should probably read "Perhaps you meant Base.IteratorSize or Iterators", as otherwise what's going wrong is a bit unclear. Something similar may also be needed for the terms displayed in the first line after search:.

This is on

julia> versioninfo()
Julia Version 1.11.0-DEV.1030
Commit b5abac441db (2023-12-06 05:12 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 8 × 11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz
  WORD_SIZE: 64
  LLVM: libLLVM-15.0.7 (ORCJIT, tigerlake)
  Threads: 1 on 8 virtual cores
Environment:
  LD_LIBRARY_PATH = :/usr/lib/x86_64-linux-gnu/gtk-3.0/modules
  JULIA_EDITOR = subl
@inkydragon inkydragon added the REPL Julia's REPL (Read Eval Print Loop) label Dec 10, 2023
@ararslan
Copy link
Member

This seems to be because names now includes public bindings, not only exported bindings. I think this could be fixed by amending the accessible function in the REPL stdlib to add isexported to the filtering and restore the original behavior.

@ararslan ararslan mentioned this issue Dec 14, 2023
Merged
KristofferC pushed a commit that referenced this issue Feb 8, 2024
@ararslan @vtjnash
Qualify public, unexported bindings in REPL help (#52524)
95df060 
Fixes #52472, which was caused by `names` being changed to also return
public, unexported symbols in #50105. Note that this restores previous
behavior. A case could be made to instead add the public, unexported
bindings as suggestions with the appropriate qualification.

Not entirely sure how to test this so I'd welcome any suggestions.

---------

Co-authored-by: Jameson Nash <vtjnash@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Qualify public, unexported bindings in REPL help JuliaLang/julia
3 participants
@inkydragon @ararslan @jishnub